-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs to clarify which telescope.defaults options can be overriden by pickers #3251
Open
clorl
wants to merge
2
commits into
nvim-telescope:master
Choose a base branch
from
clorl:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -106,18 +106,26 @@ local telescope = {} | |||||||||||||||||||||
--- pickers = { | ||||||||||||||||||||||
--- -- Default configuration for builtin pickers goes here: | ||||||||||||||||||||||
--- -- picker_name = { | ||||||||||||||||||||||
--- -- picker_config_key = value, | ||||||||||||||||||||||
--- -- default_config_key = value_one | ||||||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
--- -- picker_config_key = value_two, | ||||||||||||||||||||||
--- -- ... | ||||||||||||||||||||||
--- -- } | ||||||||||||||||||||||
--- -- Now the picker_config_key will be applied every time you call this | ||||||||||||||||||||||
--- -- builtin picker | ||||||||||||||||||||||
--- -- Options set here will be applied everytime you call this builtin | ||||||||||||||||||||||
--- -- picker. Each entry accepts a subset of the "defaults" configuration | ||||||||||||||||||||||
--- -- options, as well as the picker's own specific configuration options. | ||||||||||||||||||||||
--- -- Defaults options that are also valid for pickers are marked as | ||||||||||||||||||||||
--- -- "Picker-Overridable" in telescope.setup.defaults. Learn about one | ||||||||||||||||||||||
--- -- picker's specific set of options at telescope.builtin.$PICKER_NAME | ||||||||||||||||||||||
Comment on lines
+113
to
+118
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||||||||||
--- }, | ||||||||||||||||||||||
--- extensions = { | ||||||||||||||||||||||
--- -- Your extension configuration goes here: | ||||||||||||||||||||||
--- -- extension_name = { | ||||||||||||||||||||||
--- -- extension_config_key = value, | ||||||||||||||||||||||
--- -- } | ||||||||||||||||||||||
--- -- please take a look at the readme of the extension you want to configure | ||||||||||||||||||||||
--- -- Extensions should generally accept the same subset of defaults config | ||||||||||||||||||||||
--- -- options as builtin pickers, although that may differ depending on the | ||||||||||||||||||||||
--- -- extension. Make sure to read the extension's README or builtin | ||||||||||||||||||||||
--- -- documentation to know its specific configuration options. | ||||||||||||||||||||||
--- } | ||||||||||||||||||||||
--- } | ||||||||||||||||||||||
--- </code> | ||||||||||||||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll probably be easier to mark options that aren't "picker-overriable".
In theory, all but a small handful can at least in technically be overriden by the each individual picker.
I would reword this bit slightly and let's leave out the marking of individual options an "Picker-Overridable" for now.