-
Notifications
You must be signed in to change notification settings - Fork 1
Modularize dependency configuration #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Huh @Jacobfaib any idea why this would fail only on 3.10? Alternatively, do we need to support 3.10? |
|
I guess there were some changes to enums (and their formatting) starting in 3.11. Fixed with an explicit |
|
Not sure why Edit: doh, because there is a second workflow file.... fixed in 1739d09 pushed directly to main |
This PR modularizes the handling of package dependencies. Package name and dependencies are now specified declaratively as class vars:
All transitive dependencies of the main package are automatically collected. Dependency package instances are still available via the
depsnamespace on packages, e.g.self.deps.CUDAfor theLegionpackage above.All package definitions except
CMakeandPythonwere removed. Once this is merged and tagged 1.2.0 a separate PR will updatelegate.internalto use define and use them locally from there.This PR also enables running of unit tests in CI.