Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(InputMenu): emit focus event #2386

Open
wants to merge 6 commits into
base: v3
Choose a base branch
from
Open

fix(InputMenu): emit focus event #2386

wants to merge 6 commits into from

Conversation

tomykho
Copy link

@tomykho tomykho commented Oct 15, 2024

πŸ”— Linked issue

Resolves #2058

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR fixes a bug @focus event is not triggering for InputMenu because of InputMenuEmits is removing onFocus from $attrs.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@tomykho tomykho marked this pull request as draft October 15, 2024 11:57
@tomykho tomykho changed the title fix(InputMenu): emit focus event fix(InputMenu): emit focus event (v3) Oct 15, 2024
@tomykho tomykho marked this pull request as ready for review October 15, 2024 11:58
@benjamincanac benjamincanac added the v3 #1289 label Oct 15, 2024
@benjamincanac benjamincanac changed the title fix(InputMenu): emit focus event (v3) fix(InputMenu): emit focus event Oct 15, 2024
Copy link

pkg-pr-new bot commented Oct 15, 2024

pnpm add https://pkg.pr.new/@nuxt/ui@2386

commit: 21e8908

@benjamincanac
Copy link
Member

Thanks @tomykho. Will add the wontfix-v2 & v3 labels on the related issue. Do you think it would be possible to add an example to the docs? https://ui3.nuxt.dev/components/input-menu#examples

Something like ### Open on focus under Control open state and Control search term.

@tomykho
Copy link
Author

tomykho commented Oct 15, 2024

Thanks @tomykho. Will add the wontfix-v2 & v3 labels on the related issue. Do you think it would be possible to add an example to the docs? https://ui3.nuxt.dev/components/input-menu#examples

Something like ### Open on focus under Control open state and Control search term.

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 #1289
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants