Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Implement component #2139

Open
benjamincanac opened this issue Mar 20, 2024 · 4 comments · May be fixed by #2364
Open

[Table] Implement component #2139

benjamincanac opened this issue Mar 20, 2024 · 4 comments · May be fixed by #2364
Assignees
Labels

Comments

@benjamincanac
Copy link
Member

No description provided.

@benjamincanac benjamincanac transferred this issue from another repository Mar 27, 2024
@benjamincanac benjamincanac added the v3 #1289 label Jul 18, 2024
@benjamincanac benjamincanac transferred this issue from benjamincanac/ui3 Sep 6, 2024
@robin-dongbin
Copy link

robin-dongbin commented Oct 3, 2024

It is recommended to provide Table and DataTable separately, with the Table component only wrapping basic style variants, while other advanced features are provided in DataTable. DataTable can reuse the style variants of the Table.

I believe that Table can be prioritized for development at this stage. As for whether to use Tanstack Table or others, that can be considered when developing the DataTable, and the DataTable can inherit the style variants of the Table, which will not lead to redundant work.

refs:
[Vuetify]
https://vuetifyjs.com/en/components/tables/#usage
https://vuetifyjs.com/en/components/data-tables/introduction/#components

[Shadcn]
https://www.shadcn-vue.com/docs/components/table.html
https://www.shadcn-vue.com/docs/components/data-table.html

Copy link
Member Author

This logic works for shadcn because they provide a primitive for each HTML element of the table. However, in Nuxt UI you will still have to pass a columns and items / rows props to the Table component which will render the table. It doesn't make sense to make two components for us.

@robin-dongbin
Copy link

I will explain my reasons for your reference: First of all, I hope to have a fully controllable table content rendering method while maintaining a unified UI style. Secondly, with the increase of functional requirements, Datatable will have a lot of internal complexity, which sometimes only It is too heavy to render an ordinary table. After clarifying, I want to say that developing a separate table component will not increase much workload, because its style can be completely inherited by Datatable, and because the table component contains almost no functions, there is almost no need for maintenance in the later stage. If you think table is completely unnecessary, or for compatibility with v2, I completely understand what you are saying, just clarifying my idea 🤔

@UfukUstali
Copy link

Feature request for table. I think it would be great to also have error state just like loading or empty state.

@benjamincanac benjamincanac self-assigned this Oct 10, 2024
@benjamincanac benjamincanac linked a pull request Oct 11, 2024 that will close this issue
8 tasks
@benjamincanac benjamincanac linked a pull request Oct 11, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants