Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using TanStack Table as a headless table #653

Closed
AbdallahAlhaddad opened this issue Sep 10, 2023 · 8 comments
Closed

Using TanStack Table as a headless table #653

AbdallahAlhaddad opened this issue Sep 10, 2023 · 8 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request v3 #1289

Comments

@AbdallahAlhaddad
Copy link

What do you think about using TanStack headless table to handle table logic?

@AbdallahAlhaddad AbdallahAlhaddad added the enhancement New feature or request label Sep 10, 2023
Copy link
Member

What would be the benefit of using TanStack, what are we missing?

@ddahan
Copy link

ddahan commented Sep 11, 2023

Based on the features, I guess the OP idea is to be feature-complete without reimplementing them?

@AbdallahAlhaddad
Copy link
Author

The main idea is to eliminate the need to maintain the Javascript logic ourselves and rethinking the table api to give the ability to easily extend the table functionality by the library consumers.

I suggested TanStack Table because its popular and well-maintained headless table library as its very popular with the react ecosystem, I also noticed it is used in shadcn ui.

@ddahan
Copy link

ddahan commented Sep 14, 2023

That's a very interesting topic in my opinion an I'm curious to hear maintainers opinion.
I guess it's a little tough for them to decide when something :

  • should be a hard dependency
  • should be a soft dependency (e.g. showing an example of how to integrate the external dependency by yourself, like with Datepicker)
  • should be totally reimplemented

Because iit's all about trade-offs. The more you integrate things by yourself, the more it requires work and maintenance. However the code is probably mode robust, easier to use and debug for developers, and dedicated to your specific need.

@benjamincanac benjamincanac added the v3 #1289 label Mar 9, 2024 — with Volta.net
Copy link
Member

I'm gonna give this a shot in v3 but I don't guarantee that I will go for it 😊

@benjamincanac benjamincanac mentioned this issue Mar 14, 2024
7 tasks
@itpropro
Copy link

Hey @benjamincanac, have you tested tantack table, what was your impression and will it be powering the v3 table component? I just used it in another project and it is really great for some features that are currently missing from the nuxt ui table like column resizing, column
reordering, column/row pinning and global filtering for tables to already filter content on ssr rendering and only hydrate with the filtered data.
I would love to see resizing and reordering in the new table version, there are many use cases for that in data tables.

Copy link
Member

benjamincanac commented Sep 26, 2024

@itpropro I haven't started working on the Table component yet, I still have to finish the docs for the other components 😊 Thanks for the feedback though, it's reassuring to try it out!

@benjamincanac benjamincanac added the duplicate This issue or pull request already exists label Sep 26, 2024 — with Volta.net
Copy link
Member

Closing in favor of #2139.

@benjamincanac benjamincanac closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request v3 #1289
Projects
None yet
Development

No branches or pull requests

4 participants