fix: feature card background overlapping rounded corners on hover in dark mode #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding rounded-xl produces the same result, fwiw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
NA
❓ Type of change
📚 Description
In dark mode, hovering over a feature card makes its background overlap the card's rounded corners:
This is caused by setting a background color on the card's content in dark mode:
nuxt.com/components/home/HomeSectionFeatures.vue
Line 22 in 8a3a95b
At first I thought maybe it'd be best to address this in Nuxt UI, but Nuxt UI deliberately does not set
overflow-hiddenon the Card component that UPageCard extends: nuxt/ui#806 (comment). So I've addedoverflow-hiddento theuiobject here which contains the buggy style.