Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Propagate SVG changes in customCollections to client and server bundles without nuxt server restart #282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

leo-buneev
Copy link

@leo-buneev leo-buneev commented Oct 15, 2024

πŸ”— Linked issue

resolves #281

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

watches changes in files from customCollections directories, and on any change triggers:

  • rebuild of client icons bundle
  • rebuild of server icons bundle
  • invalidates client bundle in vite dev server

Potential future improvements (let me know if you're interested, i can create further PR):

  • debounce bundles rebuilding in case of rapid file changes
  • HMR - probably needs custom message from HMR server to Icon.vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes in *.svg files in custom collections require restarting nuxt server
1 participant