Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to latest module-builder alpha #428

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Dec 13, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this drops support for CJS usage of @nuxt/fonts, and for node10 module resolution

with the upcoming release of @nuxt/module-builder v1, we have shipped a couple of breaking changes (see nuxt/module-builder#449 for full details):

  1. we no longer emit a .cjs entrypoint for the module
  2. we do not add a cjs bridge (which polyfills things like __dirname and __filename)
  3. we do not support node10 module resolution - this affects types for the module only and has been the default for some time in Nuxt

@danielroe danielroe self-assigned this Dec 13, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 13, 2024

Deploying fonts with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: e688203
Status:Β βœ…Β  Deploy successful!
Preview URL: https://8040cf73.fonts-dsw.pages.dev
Branch Preview URL: https://module-builder-alpha.fonts-dsw.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 79.68%. Comparing base (220ebbb) to head (e688203).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   83.86%   79.68%   -4.18%     
==========================================
  Files          13       13              
  Lines        1029     1029              
  Branches      272      270       -2     
==========================================
- Hits          863      820      -43     
- Misses        160      204      +44     
+ Partials        6        5       -1     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe marked this pull request as ready for review December 13, 2024 18:13
Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@nuxt/fonts@428

commit: 4bf6bdc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants