Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use unplugin for loader #235

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: use unplugin for loader #235

wants to merge 8 commits into from

Conversation

antfu
Copy link
Member

@antfu antfu commented Sep 17, 2021

Use unplugin to support both Webpack and Vite, Using the logic from unplugin-vue-components to directly replace the component usage instead of local installation (make the codebase simpler and the runtime faster)

@antfu antfu marked this pull request as ready for review September 24, 2021 01:23
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #235 (98244f1) into main (f8667b6) will decrease coverage by 14.09%.
The diff coverage is 13.33%.

❗ Current head 98244f1 differs from pull request most recent head 539eb7d. Consider uploading reports for the commit 539eb7d to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #235       +/-   ##
===========================================
- Coverage   86.28%   72.18%   -14.10%     
===========================================
  Files           7        6        -1     
  Lines         175      169        -6     
  Branches       47       48        +1     
===========================================
- Hits          151      122       -29     
- Misses         24       47       +23     
Impacted Files Coverage Δ
src/scan.ts 98.18% <ø> (ø)
src/loader.ts 6.25% <6.25%> (-93.75%) ⬇️
src/index.ts 80.00% <25.00%> (+4.63%) ⬆️
test/unit/utils.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8667b6...539eb7d. Read the comment docs.

@atinux atinux requested a review from pi0 September 29, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant