Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(loggers): do not set minify option by default #577

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

vejja
Copy link
Collaborator

@vejja vejja commented Nov 30, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #576

This PR changes the behaviour of the removeLoggers functionality to avoid potentially breaking third-party code.

Currently, the Nuxt Security module turns on Vite's build minification option by default. In some cases, it was found that this behaviour could have side-effects on third-party code.

With this PR, we do not modify the build minify option by default anymore.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vejja vejja changed the title fix(loggers): do not set minify option y default fix(loggers): do not set minify option by default Nov 30, 2024
@vejja vejja self-assigned this Nov 30, 2024
Copy link

pkg-pr-new bot commented Nov 30, 2024

Open in Stackblitz

npm i https://pkg.pr.new/nuxt-modules/security/nuxt-security@577

commit: 833e766

@vejja vejja changed the base branch from main to chore/2.1.5 November 30, 2024 14:38
@vejja vejja changed the base branch from chore/2.1.5 to main November 30, 2024 14:40
@vejja vejja merged commit b39dbd9 into main Nov 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles break in production when using v2.1.0+
1 participant