Merge pull request #561 from Baroshem/vejja/issue559

fix(core): do not remove loggers in dev mode
nuxt-modules · Nov 19, 2024 · 5769795 · 5769795
2 parents 642bfce + f8890af
commit 5769795
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/docs/package.json b/docs/package.json
@@ -12,7 +12,7 @@
     "@nuxt-themes/docus": "^1.14.7",
     "@nuxtjs/plausible": "^1.0.0",
     "@nuxtlabs/github-module": "^1.6.3",
-    "nuxt": "^3.11.2",
+    "nuxt": "3.11.2",
     "nuxt-security": "latest"
   },
   "resolutions": {

diff --git a/playground/nuxt.config.ts b/playground/nuxt.config.ts
@@ -55,7 +55,6 @@ export default defineNuxtConfig({
       interval: 30000,
       headers: true
     },
-    removeLoggers: false,
   },
 
   hooks: {

diff --git a/playground/pages/index.vue b/playground/pages/index.vue
@@ -5,5 +5,6 @@
 </template>
 
 <script setup lang="ts">
+console.log('hello from index should be removed in production')
 const { data } = await useAsyncData(async () => await Promise.resolve("Home"));
 </script>
diff --git a/src/module.ts b/src/module.ts
@@ -65,8 +65,8 @@ export default defineNuxtModule<ModuleOptions>({
         // This method is deprecated and will be removed in the future
         addVitePlugin(viteRemove(securityOptions.removeLoggers))
 
-      } else {
-        // Uses the native method by Vite
+      } else if (!nuxt.options.dev) {
+        // Uses the native method by Vite, except in dev mode
         // Vite can use either esbuild or terser
         if (nuxt.options.vite.build?.minify === 'terser') {
           // In case of terser, set the drop_console and drop_debugger options