Chore/3.0.0 #198
Closed
Chore/3.0.0 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 23, 2024
✅ Deploy Preview for nuxt-cloudinary-module canceled.
|
colbyfayock
reviewed
Mar 24, 2024
| @@ -195,6 +198,8 @@ const handleOnLoad = () => { | |||
| ...logoOptions, | |||
| hideContextMenu, | |||
| pictureInPictureToggle, | |||
| ...useRuntimeConfig().public.cloudinary.config, | |||
There was a problem hiding this comment.
i think this need to spread the config.url in this instance, but per my Discord message, i think exposing cloudinary.url and spreading that directly might be a better experience
adding ability to pass in global module configurations
(cherry picked from commit cea1b1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist: