[CS2113-T11a-2] LogJob #31
Conversation
…nage-groups Feature manage groups
sevenseasofbri
left a comment
sevenseasofbri
left a comment
There was a problem hiding this comment.
Very good job team! I think the code is well structured and follows good code quality practices for the most part. I have briefly gone over and added some comments. Let me know if you have any questions.
| public boolean isRunning() { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
This method always returns true, so how does it track state? If this is meant to represent what this command implies (i.e. if the command the current object contains means the application continues running) then i think you should name the function something else like shouldContinue or getNextRunState
| public boolean isRunning() { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Same with this, this method always returns false...
| } | ||
| } | ||
|
|
||
| private static void containsAllFlags(HashMap<Flag, List<String>> argMap, Flag... flags) |
There was a problem hiding this comment.
This function name reads more like a boolean variable name. It does not accurately describe what the code is doing - which is checking for missing flags right. So maybe a better name would be checkMissingFlags
There was a problem hiding this comment.
Same applies to containsNoDuplicateFlags
| } | ||
| } | ||
|
|
||
| private void requireNonNullFile() throws StorageException { |
There was a problem hiding this comment.
Not exactly an apt verb for this function name. Something like checkAndCreateNonNullFile or ensureFileExists would be better.
|
|
||
| } | ||
|
|
||
| public void introMessage() { |
There was a problem hiding this comment.
| public void introMessage() { | |
| public void printIntroMessage() { |
| System.out.println(Constants.LINE_BREAK); | ||
| } | ||
|
|
||
| public void exitMessage() { |
There was a problem hiding this comment.
| public void exitMessage() { | |
| public void printExitMessage() { |
76 tokenizer preamble
Add JUnit and Assertion for UI package
…ndexOutOfBoundsException
Fix LogJob logo in Readme.md
Refactor LogJob class into a Singleton to prevent erroneous instantiation
Fix storage bug when program exits unexpectedly
Extend JUnit tests to include more error paths for DeleteCommandTest
Add Sorting Function
Add Find Command
edit zexueteh PPP
Add PPP and UG changes
Update PPP and UG
Enable assertions
link bugfix
Minor bugfix
Minor change to PPP
fix hyperlinks to repo
remove PUML guide
… 223-Link-bugfix
fix Model links and find sequence diagram
fix startup image
8 participants
LogJob
LogJob (LJ) is a desktop app for managing job applications, optimized for use via a Command Line Interface (CLI). If you can type fast, LJ can get your job application management tasks done faster than traditional GUI apps.