[CS2113-F11-4] FlashCLI #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenseasofbri
left a comment
sevenseasofbri
left a comment
There was a problem hiding this comment.
Good job team 4, I haven't added too many comments since most of your code seems fine at a quick glance (in the terms of code quality and coding standards). However, please write your documentation comments in a consistent manner because some classes have proper JavaDoc whilst others don't.
Additionally, please rename your PR to [CS2113-F11-4] FlashCLI it is incorrect right now (there is an extra F in front of 4)
| */ | ||
| private static final Logger logger = Logger.getLogger(FlashcardList.class.getName()); | ||
|
|
||
| public static String createFlashcard(String arguments) throws FlashCLIillegalArgumentException { |
There was a problem hiding this comment.
This function is a little long and difficult to read. Consider refactoring it into multiple fns.
src/main/java/flashcli/FlashCLI.java
Outdated
| * Main entry-point for the java.flashcli.FlashCLI application. | ||
| */ | ||
| public static void main(String[] args) { | ||
| //assert false : "dummy assertion set to fail"; |
There was a problem hiding this comment.
Avoid commenting out dead code. Remove it instead.
Insert Code Snippet
… unlearned Changed error message name to be more general. Added CommandChangeLearned
Also made some edits to view question tests
Quiz Timer
Mark as learned
Made user guide message clearer to follow for new users Added user_guide as a possible command
Add a userguide command so that users can view what commands and features the application has
Deck feature addons
…into branch-UG-2.0
UG 2.0 for view_res
…into felix_bug-resolves # Conflicts: # docs/UserGuide.md
Updated UG, DG and PPP
…into branch-PPP3.0
Merge branch 'master' of https://github.com/AY2425S2-CS2113-F11-4/tp …
Update PPP to fit within page limit
Update ppp betahaxer
…into felix_bug-resolves
Shortened PPP
Fix sequence diagram typo
Update UserGuide.md for Command Summary table
Edits to DG and diagrams
Update ppp betahaxer
Update ppp betahaxer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FlashCLI helps CS2113 students to create flashcards and revise content effectively.