[Deen Liong] iP #83
Open
[Deen Liong] iP #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| System.out.println("What can I do for you?"); | ||
| } | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
This function is very long (>30lines). Do consider breaking it down into multiple smaller functions.
src/main/java/duke/TaskManager.java
Outdated
|
|
||
| public class TaskManager { | ||
|
|
||
| public static void printSuccessfulAdd(Task[] tasks, int taskCount) { |
There was a problem hiding this comment.
Perhaps avoid the usage of magic literals and consider refactoring them to final variables instead.
src/main/java/duke/TaskManager.java
Outdated
|
|
||
| public static void printTaskList(Task[] tasks, int taskCount) { | ||
| System.out.println("\t_____________________"); | ||
| // if there are no task |
There was a problem hiding this comment.
This comment may be redundant. Consider removing it
| package duke.exception; | ||
|
|
||
| public abstract class DukeException extends Exception { | ||
| //no other code needed |
There was a problem hiding this comment.
You don't need to add comments where it is perhaps not necessary to do so.
src/main/java/duke/task/Task.java
Outdated
| } | ||
|
|
||
| public String getStatusIcon() { | ||
| if (isDone) { // mark done task with X |
There was a problem hiding this comment.
Maybe remove the comment here since it is redundant and the code explains itself well already.
src/main/java/duke/task/Task.java
Outdated
| public String toString() { | ||
|
|
||
| return getStatusIcon() + description; | ||
| // return getStatusIcon() ; |
There was a problem hiding this comment.
Avoid leaving commented out code in your codebase, since it reduces readability
small bug - bye now prints error message
1 - bye error message still show 2 - printing of number of items in inputFile at the start
Branch level 9
Branch level 9
Added User Guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.