[Ng Yong Jie] iP #74

yongjicode · 2022-08-31T11:54:05Z

No description provided.

owenl131

Would be good to split the code into functions or classes :)

owenl131 · 2022-09-02T03:39:36Z

src/main/java/Duke.java

+
+        //level 4
+        // list with 100 rows, 3 columns, 0 - TaskType, 1 - isDone, 2 - TaskName
+        String[][] TaskList = new String[100][3];


Please avoid using magic literals

owenl131 · 2022-09-02T03:39:54Z

src/main/java/Duke.java

+            }
+        }
+        while(true) {
+            Scanner ScannerObject4 = new Scanner(System.in);


Please start local variables with a lowercase letter

owenl131 · 2022-09-02T03:40:31Z

src/main/java/Duke.java

+            String command = input.substring(0, input.indexOf(' '));
+            String content = input.substring(input.indexOf(' ') + 1);
+
+            boolean isToDo = Objects.equals(command, "todo");


This could be command.equals("todo") instead

owenl131 · 2022-09-02T03:41:39Z

src/main/java/Duke.java

+                continue;
+            } else if (isUnmark) { //unmark task
+                int TaskNumber = Integer.parseInt(content);
+                TaskList[TaskNumber-1][1] = " ";


Please leave spaces on the left and right of operators (like +, -, etc)

mathanmahe

Good job, try to update the implementation with the latest requirements as the IP is due soon. There were some coding standard violations and improvements to code quality that I have highlighted and suggested.

mathanmahe · 2022-09-18T02:45:32Z

src/main/java/Duke.java

+        }
+        System.out.println("Bye. Hope to see you again soon!");
+
+//        // level 2 & 3


Delete dead code that is no longer in use.

mathanmahe · 2022-09-18T02:47:01Z

src/main/java/Duke.java

+
+
+        //level 4
+        // list with 100 rows, 3 columns, 0 - TaskType, 1 - isDone, 2 - TaskName


Write comments to the reader, and do not repeat the obvious in comments if it can already be inferred from the code.

Code Quality Guideline: Comment minimally but sufficiently

mathanmahe · 2022-09-18T02:48:38Z

src/main/java/Duke.java

+
+        //level 4
+        // list with 100 rows, 3 columns, 0 - TaskType, 1 - isDone, 2 - TaskName
+        String[][] TaskList = new String[100][3];


Avoid using magic numbers, good to define what these numbers represent as constants like MAX_TASK_LENGTH and MAX_NUMBER_OF_TASKS

Code quality guideline: Avoid magic numbers

mathanmahe · 2022-09-18T02:49:07Z

src/main/java/Duke.java

+            }
+        }
+        while(true) {
+            Scanner ScannerObject4 = new Scanner(System.in);


As per the Java Coding Standard, variable names must be in camelCase.

mathanmahe · 2022-09-18T02:50:55Z

src/main/java/Duke.java

+                TaskList[ListCounter][2] = content;
+                System.out.println("Got it. I've added this task:");
+                System.out.println("[" + TaskList[ListCounter][0]+"][" + TaskList[ListCounter][1]+"] " + TaskList[ListCounter][2]);
+                System.out.println("Now you have "+ (ListCounter+1) +" tasks in your list.");


Avoid long methods, consider breaking down into smaller methods.

Code Quality Guideline: Avoid Long Methods

mathanmahe · 2022-09-18T02:51:21Z

src/main/java/Duke.java

+                TaskList[ListCounter][2] = content;
+                System.out.println("Got it. I've added this task:");
+                System.out.println("[" + TaskList[ListCounter][0]+"][" + TaskList[ListCounter][1]+"] " + TaskList[ListCounter][2]);
+                System.out.println("Now you have "+ (ListCounter+1) +" tasks in your list.");


Ensure that your operators are preceded and followed by whitespaces, as per the Java coding standard.

mathanmahe · 2022-09-18T02:51:52Z

src/main/java/Duke.java

+                System.out.println("Got it. I've added this task:");
+                System.out.println("[" + TaskList[ListCounter][0]+"][" + TaskList[ListCounter][1]+"] " + TaskList[ListCounter][2]);
+                System.out.println("Now you have "+ (ListCounter+1) +" tasks in your list.");
+            } else if (isDeadline) { // add deadline to list


As per the Java Coding Standard, ensure that comments are indented relative to their position in the code.

Ng Yong Jie added 7 commits August 30, 2022 16:53

Update Duke.java

c7b5a0d

Update Duke.java

61d5b15

Update Duke.java

369e45d

Update Duke.java

a46cc46

Update Duke.java

b19cd2a

Update Duke.java

4fdc20b

Update Duke.java

2849334

owenl131 reviewed Sep 2, 2022

View reviewed changes

mathanmahe reviewed Sep 18, 2022

View reviewed changes

Ng Yong Jie added 10 commits September 23, 2022 01:05

Update duke using classes

7bbcc1b

Add error handling for incorrect inputs

6645407

Add delete function to TaskList

77afe90

Add error catching for incorrect commands

8b5fbef

Add save feature to save TaskList to txt file

4656228

Clean some code and make duke more OOP

71666f3

Add find feature for users to find a task by searching for a keyword

87546b4

Add header comments to non-private classes and methods

a578e50

Add User Guide

1767cb1

Update User Guide

a7b25f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ng Yong Jie] iP #74

[Ng Yong Jie] iP #74

yongjicode commented Aug 31, 2022

owenl131 left a comment

owenl131 Sep 2, 2022

owenl131 Sep 2, 2022

owenl131 Sep 2, 2022

owenl131 Sep 2, 2022

mathanmahe left a comment

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022



		//level 4
		// list with 100 rows, 3 columns, 0 - TaskType, 1 - isDone, 2 - TaskName

[Ng Yong Jie] iP #74

Are you sure you want to change the base?

[Ng Yong Jie] iP #74

Conversation

yongjicode commented Aug 31, 2022

owenl131 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mathanmahe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment