[Aaron Chan Zhi] iP #73

AaaaaronC · 2022-08-31T10:35:31Z

No description provided.

Brandon-OS

Awesome job on finishing until Level 4! Great utilization of libraries!

Brandon-OS · 2022-09-01T09:48:20Z

src/main/java/ToDo.java

@@ -0,0 +1,9 @@
+public class ToDo extends Task {
+
+    public ToDo(String description){


Consider adding spaces in between method name and inputs

Brandon-OS · 2022-09-01T09:50:21Z

src/main/java/Duke.java

+                        }
+                    }
+                    if (byPosition == 0){
+                        System.out.println("Please state the deadline!");


Good job on adding error handling!

Brandon-OS · 2022-09-01T09:50:52Z

src/main/java/Duke.java

-            String cmd = input_list[0];
+            String rawInput = scanner.nextLine();
+            String[] inputList = rawInput.split(" ");
+            String cmd = inputList[0];


Consider writing variable names in full to make it more readable

Brandon-OS · 2022-09-01T09:53:40Z

src/main/java/Duke.java

+                    System.out.println("---------------------------------------------------");
+                    int atPosition = 0;
+                    String dateTime;
+                    for (int i=0; i<inputList.length; i++){


Consider adding spaces in between calculations

matthewphua · 2022-09-01T09:50:43Z

src/main/java/Duke.java

+
+        while (isExit == false){
+            //Getting Input
+            System.out.println("---------------------------------------------------");


potentially add ---------... as a constant to increase readability of print statements.

matthewphua · 2022-09-01T09:53:20Z

src/main/java/Duke.java

+
+            //Responding
+            switch (cmd) {
+                case ("list"):


Avoid magic strings, so maybe for each of these cases, you can say for ex: LIST = "list" and reference the constant in the if statement

matthewphua · 2022-09-01T09:54:12Z

src/main/java/Duke.java

+        System.out.println("Duke: Hello! What can I do for you today?");
+
+
+        while (isExit == false){


Break this function into smaller helper functions :) to increase readability.

matthewphua · 2022-09-01T09:55:27Z

src/main/java/Event.java

+    public Event(String description, String dateTime){
+        this.description = description;
+        this.isDone = false;
+        this.taskType = "E";


make taskType a static final variable and instantiate it not in the constructor

matthewphua · 2022-09-01T09:57:02Z

src/main/java/Task.java

+    }
+
+    public void markAsNotDone(){
+        if (isDone==true) this.isDone = false;


just do:
if (isDone) {
this.isDone = false;
}

matthewphua · 2022-09-01T09:58:31Z

src/main/java/TaskList.java

+    public Task searchTask(String task_description){
+        for (int i=0; i<size; i++){
+            Task tempTask = this.getTask(i);
+            if (tempTask.description.equals(task_description)) return tempTask;


make sure to do brackets after the if statement and a line break for "return tempTask"

matthewphua · 2022-09-01T09:59:31Z

src/main/java/TaskList.java

+        for (int i=0; i<size; i++){
+            Task tempTask = this.getTask(i);
+            String taskType = tempTask.getTaskType();
+            if (taskType == "T"){


Magic String, maybe set "T" as a constant TASK = "T" so its easier for readers to know that T corresponds to task :)

jjtoh

Some repeated mistakes in the spacing and can make code more readable by putting some code in a new method.

jjtoh · 2022-09-01T09:45:12Z

src/main/java/Duke.java

+            String description;
+
+            //Responding
+            switch (cmd) {


Can do the printing in another method to make the code look cleaner

Indentation not needed for switch and case statements

jjtoh · 2022-09-01T09:47:58Z

src/main/java/Duke.java

+        System.out.println("Duke: Hello! What can I do for you today?");
+
+
+        while (isExit == false){


Add a space before opening the braces for better styling.

jjtoh · 2022-09-01T09:49:25Z

src/main/java/Duke.java

+            System.out.print("You: ");
+            String rawInput = scanner.nextLine();
+            String[] inputList = rawInput.split(" ");
+            String cmd = inputList[0];


Name of variable can be improve, for example rather than cmd, it can be command

jjtoh · 2022-09-01T09:50:15Z

src/main/java/TaskList.java

+        for (int i=0; i<size; i++){
+            Task tempTask = this.getTask(i);
+            String taskType = tempTask.getTaskType();
+            if (taskType == "T"){


All the printing can be done in a method to prevent repetition

jjtoh · 2022-09-01T09:55:55Z

src/main/java/Deadline.java

+public class Deadline extends Task {
+    private String dueDate;
+
+    public Deadline(String description, String dueDate){


There should be spacing before braces (applies the whole file)

jjtoh · 2022-09-01T10:03:34Z

src/main/java/Task.java

+    }
+
+    public void markAsDone() {
+        if (isDone==false) this.isDone = true;


Add spaces before and after the logical operator so that it looks better

shengiv

There are no major coding standard violations. Good job!

shengiv · 2022-09-01T09:40:51Z

src/main/java/Duke.java

 public class Duke {
    public static void main(String[] args) {
+        boolean isExit = false;


An alternative name can be used for the boolean isExit so that the purpose of the boolean is clearer

shengiv · 2022-09-01T09:43:54Z

src/main/java/Duke.java

+            String description;
+
+            //Responding
+            switch (cmd) {


The switch statement should be aligned with the case statements.

shengiv · 2022-09-01T09:50:59Z

src/main/java/Duke.java

+                    System.out.println("---------------------------------------------------");
+                    int byPosition = 0;
+                    String dueDate;
+                    for (int i=0; i<inputList.length; i++){


You could consider adding spaces before and after comparison operators to improve readability

shengiv · 2022-09-01T10:15:50Z

src/main/java/Duke.java

+            System.out.print("You: ");
+            String rawInput = scanner.nextLine();
+            String[] inputList = rawInput.split(" ");
+            String cmd = inputList[0];


You could consider renaming the variable to "command" so that it is clearer to the reader

exetr

Great work on the iP, you can further improve by adding onto the consistency of aspects such as layout of your code generally!

exetr · 2022-09-17T17:10:53Z

src/main/java/Duke.java

+        System.out.println("---------------------------------------------------");
+    }
+
+    private static String getStringFromList(String[] inputList, int fromIndex, int toIndex) throws IllegalArgumentException{


Perhaps you can maintain consistency in adding a space before the opening brace of function declarations.

exetr · 2022-09-17T17:17:09Z

src/main/java/FileHandler.java

+
+    public static void initFiles(){
+        File dataDir = new File("./DataDir");
+        if (!dataDir.exists()) dataDir.mkdir();


Consider enclosing the dataDir.mkdir() in braces as stated in the coding standard to maintain consistency and readibility.

exetr · 2022-09-17T17:17:24Z

src/main/java/Duke.java

+                case ("event"):
+                    printLine();
+                    int atPosition = 0;
+                    String dateTime;
+                    for (int i=0; i<inputList.length; i++){
+                        if (inputList[i].equals("at")){
+                            atPosition = i;
+                            break;
+                        }
+                    }
+
+                    //Handle invalid input
+                    try{
+                        description = getStringFromList(inputList, 1, atPosition);
+                        dateTime = getStringFromList(inputList, atPosition+1, inputList.length);
+                    } catch (IllegalArgumentException e){
+                        System.out.println("Invalid input: task/date not given!");
+                        break;
+                    }
+


In such situations where a particular feature may require extensive code to achieve, it may be better for readibility to abstract the relevant blocks of code to separate functions (SLAP)

exetr · 2022-09-17T17:18:09Z

src/main/java/FileHandler.java

+        if (!dataDir.exists()) dataDir.mkdir();
+
+        try{
+            File dataFile = new File("./DataDir/Data.txt");


It would be great to eliminate the use of magic strings, in this case, consider replacing this with a variable or static variable instead!

exetr · 2022-09-17T17:19:13Z

src/main/java/FileHandler.java

+            if (taskType == "T"){
+                String line = "T | [ ] | " + task.description + "\n";
+                myWriter.write(line);
+                Lines.add(line);
+            } else if (taskType == "E"){
+                String line = "E | [ ] | " + task.description + " | " + task.getDateTime() + "\n";
+                myWriter.write(line);
+                Lines.add(line);
+            } else if (taskType == "D"){
+                String line = "D | [ ] | " + task.description + " | " + task.getDueDate() + "\n";
+                myWriter.write(line);
+                Lines.add(line);
+            } 
+
+            myWriter.close();
+        } catch (IOException e) {
+            System.out.println("An error occurred.");
+            return;
+        }
+    }


It would be good to ensure consistency by including a space after the if-else condition statements for each block, as you have done below.

exetr · 2022-09-17T17:20:56Z

src/main/java/Duke.java

+
+                case ("delete"):
+                    printLine();
+                    int tasknumber = Integer.parseInt(inputList[1]);


You can consider naming the variable taskNumber instead, in adherence to good naming practices of applying camel case for your variable names

exetr · 2022-09-17T17:24:29Z

src/main/java/TaskList.java

+        for (int i=0; i<size; i++){
+            index = i;
+            Task tempTask = this.getTask(i);
+            if (tempTask.description.equals(task_description)) return index;


It would be great to enclose the if-else block in multiple lines, and add braces to return index; in this case, to better adhere to coding standards

exetr · 2022-09-17T17:27:31Z

src/main/java/FileHandler.java

+    public static void markAsDone(int index){
+        String oldLine = Lines.get(index);
+        String newLine = oldLine.substring(0,5) 
+                        + "X" 
+                        + oldLine.substring(6, oldLine.length());
+        Lines.set(index, newLine);
+
+        try{
+            //Erase Data
+            File dataFile = new File("./DataDir/Data.txt");
+            FileWriter myWriter = new FileWriter(dataFile);
+            myWriter.write("");
+            myWriter.close();
+
+            //Replace Data
+            dataFile = new File("./DataDir/Data.txt");
+            myWriter = new FileWriter(dataFile, true);
+            for (int i=0; i < Lines.size(); i++){
+                myWriter.write(Lines.get(i));
+            }
+            myWriter.close();
+        } catch (IOException e){
+            System.out.println("An error occurred.");
+            return;
+        }
+    }
+
+    public static void markAsNotDone(int index){
+        String oldLine = Lines.get(index);
+        String newLine = oldLine.substring(0,5) 
+                        + " " 
+                        + oldLine.substring(6, oldLine.length());
+        Lines.set(index, newLine);
+
+        try{
+            //Erase Data
+            File dataFile = new File("./DataDir/Data.txt");
+            FileWriter myWriter = new FileWriter(dataFile);
+            if (!dataFile.exists()) dataFile.createNewFile();


I see there is a good amount of repeated logic within this two functions, perhaps you may want to consider further abstracting out some of the repeated functions with a helper function to improve code readibility?

Branch level 9

Branch-UG

Add: Feature List

Fix: Feature List new lines

Add: list

Added: all features

Fix: small errors in formatting

Add: intro paragraph

AaaaaronC added 6 commits August 25, 2022 11:36

Add: Level 0 (Greet)

e85afad

Level 1 (Greet, Echo, Exit)

52a99bb

Add: Level 1 (Greet, Echo, Exit)

150fe48

Add: Level 2 (Add, List)

331f166

Add: Level 3 (Mark as done)

fa24764

Add: Level 4 (ToDo, Event, Deadline)

b8d7ebf

Brandon-OS reviewed Sep 1, 2022

View reviewed changes

matthewphua reviewed Sep 1, 2022

View reviewed changes

jjtoh reviewed Sep 1, 2022

View reviewed changes

shengiv reviewed Sep 1, 2022

View reviewed changes

AaaaaronC added 5 commits September 8, 2022 11:53

Add: Level 5(Handle Errors)

8226e88

Remove: unnecessary package

468217a

Add: Level 6 (Delete)

57f5e5b

Add: Level 7 (Save)

c84fc42

Merge: Level-6 and Level-7

7878253

exetr reviewed Sep 17, 2022

View reviewed changes

AaaaaronC and others added 14 commits September 27, 2022 15:46

Add: Accounted for adding task with same name

6f0ba3e

Add: Level 8 (More OOP)

ef55e2a

Add: More OOP

0dc6154

Add: Level 9 (Find)

220ffab

Add: branch-Level-9

7b7655d

Add: Javadoc comments

d2d116b

Merge branch 'master' of https://github.com/AaaaaronC/ip

0d3c5f2

Merge branch 'master' into branch-Level-9

a896371

Merge pull request #2 from AaaaaronC/branch-Level-9

535e3d5

Branch level 9

Add: Feature List

700f8dc

Merge pull request #3 from AaaaaronC/branch-UG

58d565c

Branch-UG

Add: Feature List

6e29fb5

Merge pull request #4 from AaaaaronC/branch-UG

8b48fe4

Add: Feature List

Fix: Feature List new lines

45f6814

AaaaaronC and others added 9 commits September 30, 2022 20:05

Merge pull request #5 from AaaaaronC/branch-UG

4952e2e

Fix: Feature List new lines

Add: list

02a4770

Merge pull request #6 from AaaaaronC/branch-UG

bb1accf

Add: list

Added: all features

15debf3

Merge pull request #7 from AaaaaronC/branch-UG

16e254f

Added: all features

Fix: small errors in formatting

afdc14c

Merge pull request #8 from AaaaaronC/branch-UG

a2517fd

Fix: small errors in formatting

Add: intro paragraph

8d80670

Merge pull request #9 from AaaaaronC/branch-UG

64900ab

Add: intro paragraph

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Aaron Chan Zhi] iP #73

[Aaron Chan Zhi] iP #73

AaaaaronC commented Aug 31, 2022

Brandon-OS left a comment

Brandon-OS Sep 1, 2022

Brandon-OS Sep 1, 2022

Brandon-OS Sep 1, 2022

Brandon-OS Sep 1, 2022

matthewphua Sep 1, 2022

matthewphua Sep 1, 2022

matthewphua Sep 1, 2022

matthewphua Sep 1, 2022

matthewphua Sep 1, 2022

matthewphua Sep 1, 2022

matthewphua Sep 1, 2022

jjtoh left a comment

jjtoh Sep 1, 2022

jjtoh Sep 1, 2022

jjtoh Sep 1, 2022

jjtoh Sep 1, 2022

jjtoh Sep 1, 2022

jjtoh Sep 1, 2022

jjtoh Sep 1, 2022

shengiv left a comment

shengiv Sep 1, 2022

shengiv Sep 1, 2022

shengiv Sep 1, 2022

shengiv Sep 1, 2022

exetr left a comment

exetr Sep 17, 2022

exetr Sep 17, 2022

exetr Sep 17, 2022

exetr Sep 17, 2022

exetr Sep 17, 2022

exetr Sep 17, 2022

exetr Sep 17, 2022

exetr Sep 17, 2022

		@@ -0,0 +1,9 @@
		public class ToDo extends Task {

		public ToDo(String description){

		System.out.println("Duke: Hello! What can I do for you today?");


		while (isExit == false){

[Aaron Chan Zhi] iP #73

Are you sure you want to change the base?

[Aaron Chan Zhi] iP #73

Conversation

AaaaaronC commented Aug 31, 2022

Brandon-OS left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjtoh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shengiv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

exetr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment