[ishitamandal06] iP #71

ishitamandal06 · 2022-08-31T10:12:00Z

No description provided.

AaaaaronC

neat code, good job!

AaaaaronC · 2022-09-01T09:28:53Z

src/main/java/Duke.java

+                    System.out.println("\t"+(i+1)+". "+ inputs.get(i) );
+                }
+                System.out.println("____________________________________________________________");
+            }


the ' else{ ' line should be on this line instead of the next line

insafhere · 2022-09-01T09:38:17Z

src/main/java/Duke.java

+                for(int i=0;i< inputs.size();i++){
+                    System.out.println("\t"+(i+1)+". "+ inputs.get(i) );


Might want to include one space character for example "int i = 0 ; i < inputs.size() ; i++"

AaaaaronC · 2022-09-01T10:00:22Z

src/main/java/Duke.java

+                for(int i=0;i< inputs.size();i++){
+                    System.out.println("\t"+(i+1)+". "+ inputs.get(i) );
+                }
+                System.out.println("____________________________________________________________");


this line makes the code look long and messy, maybe can be replaced with a helper function defined above

AaaaaronC · 2022-09-01T10:01:29Z

src/main/java/Duke.java

+        String inputText = "";
+        List<String> inputs = new ArrayList<>();
+        boolean isRunning = true;
+        while(isRunning){


spaces can be put in between like so: "while (isRunning) { "

AaaaaronC · 2022-09-01T10:03:20Z

src/main/java/Duke.java

+                        "\tadded: "+inputText +"\n"+
+                        "____________________________________________________________\n");
+            }
+


unnecessary empty line here

AaaaaronC · 2022-09-01T10:04:14Z

src/main/java/Duke.java

+            else{
+                inputs.add(inputText);
+                System.out.println("____________________________________________________________\n" +
+                        "\tadded: "+inputText +"\n"+


good that the string is segmented to avoid overly long lines of code. however, indents can be made to align the string to make it more readable

xseh

Good effort! Please consider making the entire code more readable with more SLAP, following the coding standards (take note of spacings) and avoiding complicated expressions as well as magic numbers.

xseh · 2022-09-07T13:58:30Z

src/main/java/Deadline.java

@@ -0,0 +1,14 @@
+public class Deadline extends Task{


The code does not comply with coding standards, perhaps you can consider adding space between Task and {.

xseh · 2022-09-07T14:00:37Z

src/main/java/Duke.java

+        } else if (arr[0].equals("deadline")) {
+            tasks[taskCount++] = new Deadline(inputText.substring(9,inputText.indexOf('/')),inputText.substring(inputText.indexOf('/')+4));
+        }else {
+            tasks[taskCount++] = new Event(inputText.substring(6,inputText.indexOf('/')),inputText.substring(inputText.indexOf('/')+4));
+        }


Avoid complicated expressions. Consider abstracting the details into other functions or break down the logic into mutiple statements. Please take note of the length of the code and avoid long methods.

xseh · 2022-09-07T14:03:46Z

src/main/java/Duke.java

+        int position = Integer.parseInt(inputText.substring(inputText.length()-1));
+        if ((inputText.substring(0,4).equals("mark"))){
+            tasks[position-1].markAsDone();


Avoid using magic literals. Consider putting the numbers into variables to make the code more easily understood. For example, 0 can be put iinto a variable STARTING_INDEX_OF_COMMAND_STRING.

xseh · 2022-09-07T14:04:47Z

src/main/java/Duke.java

+            tasks[position-1].markAsDone();
+            System.out.println("Nice! I've marked this task as done:");
+
+        }else{


The code does not comply with the coding standards. Please consider adding spaces between }, else and {.

xseh · 2022-09-07T14:07:39Z

src/main/java/Duke.java

+            if(inputText.equals("bye")) {
+                isRunning = false;
+                showExitMessage();
+            } else if (inputText.equals("list")) {
+                handleListMessage();
+            }else if ((inputText.substring(0,4).equals("mark")) || inputText.substring(0,6).equals("unmark") ) {
+                handleMarkMessage();


The code can be further improved with more abstraction (SLAP).

xseh · 2022-09-07T14:09:06Z

src/main/java/Task.java

+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X


Avoid complicated expressions, consider seperating the logic to make the code more understandable. Also remember to remove uneeded comments after making the statements clear (i.e. comments should avoid stating the obvious).

xseh · 2022-09-07T14:10:40Z

src/main/java/Task.java

+        return "[" + this.getStatusIcon()+"] " + this.description;
+    }
+
+    //...


Please consider removing this comment because it serves no purpose.

level-9

ishitamandal06 added 3 commits August 31, 2022 17:47

level 0

812b9de

level 1

9a8d258

level 2

9fa13dc

AaaaaronC reviewed Sep 1, 2022

View reviewed changes

insafhere reviewed Sep 1, 2022

View reviewed changes

AaaaaronC reviewed Sep 1, 2022

View reviewed changes

ishitamandal06 added 2 commits September 3, 2022 16:16

level-3

fafcfeb

level-4

761792c

xseh reviewed Sep 7, 2022

View reviewed changes

ishitamandal06 and others added 13 commits September 14, 2022 09:37

level-5

2eeed1b

level-6

4d4fce0

level-7

6ff3917

merge branch-level-7

52bf70d

more OOP - Tasklist,Parser,UI class

64bcb9d

level-9

eb1a81e

Merge pull request #1 from ishitamandal06/branch-level-9

16aa926

level-9

A-JavaDoc

67058f8

A-UserGuide

f01a4dc

update JavaDoc

0ecc751

A-JAR

868e212

bug fixes - JAR

302bf5b

adding jar file to main folder

9583209

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ishitamandal06] iP #71

[ishitamandal06] iP #71

ishitamandal06 commented Aug 31, 2022

AaaaaronC left a comment

AaaaaronC Sep 1, 2022

insafhere Sep 1, 2022

AaaaaronC Sep 1, 2022

AaaaaronC Sep 1, 2022

AaaaaronC Sep 1, 2022

AaaaaronC Sep 1, 2022

xseh left a comment

xseh Sep 7, 2022

xseh Sep 7, 2022

xseh Sep 7, 2022

xseh Sep 7, 2022

xseh Sep 7, 2022

xseh Sep 7, 2022

xseh Sep 7, 2022

		for(int i=0;i< inputs.size();i++){
		System.out.println("\t"+(i+1)+". "+ inputs.get(i) );

[ishitamandal06] iP #71

Are you sure you want to change the base?

[ishitamandal06] iP #71

Conversation

ishitamandal06 commented Aug 31, 2022

AaaaaronC left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xseh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment