Syed Omar Zoran iP #67

zoranabc201 · 2022-08-30T14:13:50Z

No description provided.

ngdeqi

Looks ok overall, just small coding standard problems

ngdeqi · 2022-09-02T03:43:36Z

src/main/java/Duke.java

@@ -1,28 +1,48 @@
 import java.util.Scanner;
 public class Duke {
+    Tasks taskList[] = new Tasks[100];


Maybe you can avoid using magic numbers?

ngdeqi · 2022-09-02T03:44:42Z

src/main/java/Duke.java

    void printWelcome() {
        System.out.println("Hello I'm Duke\nWhat can I do for you?");
    }
    void acceptCommands() {
        Scanner input = new Scanner(System.in);
        String command;
-        String commandList[] = new String[100];
        int noOfCommands = 0;
        do {
            command = input.nextLine();
            if(command.equals("list")) {


Perhaps you can add a space between "if" and "("

ngdeqi · 2022-09-02T03:46:30Z

src/main/java/Duke.java

+                unmarkTasks(Integer.parseInt(command.substring(command.lastIndexOf(' ') + 1)));
+                continue;
+            }
+
            System.out.println("added: "+command);


Maybe you can add spaces between "added: ", "+" and "command"

ngdeqi · 2022-09-02T03:48:29Z

src/main/java/Tasks.java

+public class Tasks {
+    String taskName;
+    boolean done;
+    Tasks() {


Maybe you could add a "public " before the constructor?

wilsonngja

Overall great effort. Try to put white space in between expressions and make your function name more meaningful to the task it perform.

wilsonngja · 2022-09-02T04:11:28Z

src/main/java/Duke.java

+    }
+    void markTasks(int taskNumber) {
+        System.out.println("Nice! I've marked this task as done:");
+        taskList[taskNumber-1].setDone(true);


Try to put a space between previous and next text.

wilsonngja · 2022-09-02T04:12:47Z

src/main/java/Duke.java

+                continue;
+            }
+            if(command.indexOf(' ') > 0 && command.substring(0,command.indexOf(' ')).equals("mark")) {
+                markTasks(Integer.parseInt(command.substring(command.lastIndexOf(' ') + 1)));


Since you're only marking one task, don't have to put plural. markTask is suffice.

wilsonngja · 2022-09-02T04:13:48Z

src/main/java/Duke.java

+                displayList(noOfCommands);
+                continue;
+            }
+            if(command.indexOf(' ') > 0 && command.substring(0,command.indexOf(' ')).equals("mark")) {


Try to add a variable to it. Reading the statement can be difficult especially when the condition is long.

wilsonngja · 2022-09-02T04:14:56Z

src/main/java/Duke.java

+            taskList[noOfCommands] = new Tasks();
+            taskList[noOfCommands++].setTaskName(command);
+        }
+        while(!command.equals("bye"));


Try to have a variable for this boolean expression to be more intuitive.

wilsonngja · 2022-09-02T04:15:40Z

src/main/java/Duke.java

+    void printWelcome() {
+        System.out.println("Hello I'm Duke\nWhat can I do for you?");
+    }
+    void acceptCommands() {


Since you're only accepting 1 command, don't have to put plural. acceptCommand is sufficient.

* commit 'a0d42feff8f25a421e59ee0399f305e68f2673b4': Change exception message

mathanmahe

Good work on the implementation! There are some repeated coding standard violations so do be mindful of those. Consider refactoring where needed to improve readability.

mathanmahe · 2022-09-17T17:00:37Z

src/main/java/Duke/Deadline.java

+    void initializeMessage() {
+        System.out.println("Got it! I've added this task:");
+        displayMessage();
+        System.out.println("Now you have "+ TaskManager.noOfTasks +" tasks in the list.");


As per the Java coding standard it is recommended to have white spaces before and after your "+" operator.

mathanmahe · 2022-09-17T17:08:18Z

src/main/java/Duke/Tasks.java

+        return taskName;
+    }
+
+    public String taskDoneStatus() {


Names representing methods should be verbs, as per the Java coding standard. getTaskDoneStatus() would be better.

mathanmahe · 2022-09-17T17:12:16Z

src/main/java/Duke/Tasks.java

+
+public class Tasks {
+    String taskName;
+    boolean done;


Booleans should be made to sound like booleans, as per the Java coding standard.

mathanmahe · 2022-09-17T17:14:56Z

src/main/java/Duke/Duke.java

+    }
+
+    void acceptInput() {
+        Scanner SC = new Scanner(System.in);


Variable names must be in camelCase, fully uppercase names are reserved for constants.

mathanmahe · 2022-09-17T17:16:06Z

src/main/java/Duke/Duke.java

+
+    void acceptInput() {
+        Scanner SC = new Scanner(System.in);
+        TaskManager TM = new TaskManager();


As mentioned above, variable names should be in camelCase.

mathanmahe · 2022-09-17T17:17:25Z

src/main/java/Duke/Event.java

+    void initializeMessage() {
+        System.out.println("Got it! I've added this task:");
+        displayMessage();
+        System.out.println("Now you have "+ TaskManager.noOfTasks +" tasks in the list.");


Operators should be surrounded by a space character, as per the Java coding standard.

mathanmahe · 2022-09-17T17:21:34Z

src/main/java/Duke/DukeException.java

+    void notRecognizedException() {
+        System.out.println("OOPS!!! I'm sorry, but I don't know what that means :-(");
+    }
+    void taskOutOfBounds() {


Can be renamed to taskOutofBoundsException to be consistent with the other methods here.
Code Quality Guideline: Name Well

mathanmahe · 2022-09-17T17:23:15Z

src/main/java/Duke/DukeException.java

+package Duke;
+
+public class DukeException {
+    void todoException() {


Interesting use of methods to display exception messages. Since these are methods, their naming should be represented using verbs. throwTodoException() and so on would be better.

Add java-doc documentation

zoranabc201 added 8 commits August 26, 2022 16:35

Add Welcome message

a088dd8

Add welcome message

841b4ff

Refactor object name

6475446

Add comment

670b43b

Add echo commands

d9b68ef

Remove test comment

bf87317

Add list function

616ecc2

Add mark/unmark tasks. Add Tasks as class

e47ed40

ngdeqi reviewed Sep 2, 2022

View reviewed changes

wilsonngja reviewed Sep 2, 2022

View reviewed changes

zoranabc201 added 9 commits September 4, 2022 21:07

Fix coding standard violations

7c21825

Add OOP features

2d1db58

Fix bugs related to mark/unmark. Add text-ui tests

7c4ff28

Change exception message

a0d42fe

Merge commit 'a0d42feff8f25a421e59ee0399f305e68f2673b4'

6b7636d

* commit 'a0d42feff8f25a421e59ee0399f305e68f2673b4': Change exception message

Add package

026b055

Add delete function

ab97989

Change to ArrayList from Array

1c4b471

Merge branch 'branch-Level-6'

8a41413

mathanmahe reviewed Sep 17, 2022

View reviewed changes

zoranabc201 and others added 8 commits October 9, 2022 19:10

Add save feature. Refactor for more OOP

4acf673

Add some documentation

4dc8746

Add find feature

cd3e4c7

Fix bug with displaying tasks even when there is only 1 task

1a25194

Add java-doc documentation

c46edeb

Merge pull request #1 from zoranabc201/Java-Doc

17dcb41

Add java-doc documentation

Add user guide

d37c84d

Add final changes before release

97e7ed7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Syed Omar Zoran iP #67

Syed Omar Zoran iP #67

zoranabc201 commented Aug 30, 2022

ngdeqi left a comment

ngdeqi Sep 2, 2022

ngdeqi Sep 2, 2022

ngdeqi Sep 2, 2022

ngdeqi Sep 2, 2022

wilsonngja left a comment

wilsonngja Sep 2, 2022

wilsonngja Sep 2, 2022

wilsonngja Sep 2, 2022

wilsonngja Sep 2, 2022

wilsonngja Sep 2, 2022

mathanmahe left a comment

mathanmahe Sep 17, 2022

mathanmahe Sep 17, 2022

mathanmahe Sep 17, 2022

mathanmahe Sep 17, 2022

mathanmahe Sep 17, 2022

mathanmahe Sep 17, 2022

mathanmahe Sep 17, 2022

mathanmahe Sep 17, 2022

Syed Omar Zoran iP #67

Are you sure you want to change the base?

Syed Omar Zoran iP #67

Conversation

zoranabc201 commented Aug 30, 2022

ngdeqi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wilsonngja left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mathanmahe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment