[Javier Ong Ding Quan] IP #64

jeyvia · 2022-08-30T01:50:22Z

Levels-1,2,3 completed so far, Level-4 wip.

LokQiJun

Very nicely organised :)

LokQiJun · 2022-08-31T03:41:59Z

src/main/java/TaskList.java

@@ -0,0 +1,57 @@
+public class TaskList {
+    Task[] list = new Task[100];


Naming needs to be more specific

LokQiJun · 2022-08-31T03:53:10Z

src/main/java/Duke.java

+            } else if (input.contains("unmark")) {
+                list.unmarkStatus(input);
+            } else if (input.contains("mark")) {
+                list.markStatus(input);


Consider using constants rather than magic strings

LokQiJun · 2022-08-31T03:53:56Z

src/main/java/Duke.java

@@ -1,39 +1,25 @@
 import java.util.Scanner;


Good that you only imported the library that you need!

LokQiJun · 2022-08-31T03:55:36Z

src/main/java/TaskList.java

+        System.out.println("Bye. Hope to see you again soon!");
+        printLine();
+    }
+    public void addTask(String input) {


Good that you followed the naming convention :)

jingwei55

Overall the code is understandable, keep it up! Some issues need to be resolved to make your code more readable.

jingwei55 · 2022-08-31T05:41:37Z

src/main/java/TaskList.java

+        int number = Integer.parseInt(instructions[1]);
+        list[number-1].isDone = false;


Can be more specific, perhaps could use index instead of number

jingwei55 · 2022-08-31T05:45:11Z

src/main/java/TaskList.java

+    public void markStatus(String input) {
+        String[] instructions = input.split(" ");
+        int number = Integer.parseInt(instructions[1]);
+        list[number-1].isDone = true;
+        printLine();
+        System.out.println("Nice! I've marked this task as done:");
+        System.out.println("  [X] " + list[number-1].description);
+        printLine();
+    }


Could be better if markStatus and unmarkStatus came from a more generic function. Both functions are very similar, hence there should be less repeat code

jingwei55 · 2022-08-31T05:47:38Z

src/main/java/Task.java

+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X


Try to minimize the usage lambda functions if possible as they make code less readable

jingwei55 · 2022-08-31T05:49:48Z

src/main/java/TaskList.java

+        Task t = new Task(input);
+        list[index] = t;


Declaration of task can be more specific

Not complete with exceptions

okkhoy

Generally, the code is quite ok.
There are some specific things I have mentioned in the comments that help to improve readability/maintainability of the code. Please check out.

okkhoy · 2022-09-19T01:31:29Z

src/main/java/Duke.java

@@ -1,10 +1,83 @@
+import consoleCommands.ConsoleCommands;
+import exception.*;


Please import classes explicitly

okkhoy · 2022-09-19T01:33:48Z

src/main/java/Duke.java

+            } else {
+                try {
+                    ConsoleCommands.addTask(input, taskList);
+                } catch (InvalidArgumentsException e) {
+                    System.out.println(INVALID_ARGUMENTS_ERROR_MESSAGE);
+                    ConsoleCommands.printLine();
+                } catch (InvalidCommandException e) {
+                    System.out.println(COMMAND_DOES_NOT_EXIST_ERROR_MESSAGE);
+                    ConsoleCommands.printLine();
+                } catch (NotEnoughArgumentsException e) {
+                    System.out.println(NOT_ENOUGH_ARGUMENTS_ERROR_MESSAGE);
+                    ConsoleCommands.printLine();
+                }


Oh! no no... this is not very good to default the behavior for a single command.

Hi Prof! I'm not quite sure what it means to "default the behavior for a single command", could you kindly clarify? Thank you!

okkhoy · 2022-09-19T01:34:12Z

src/main/java/consoleCommands/ConsoleCommands.java

+    public static final String BYE_MESSAGE = "Bye. Hope to see you again soon!";
+    public static void printLine() {
+        System.out.println("____________________________________________________________");
+    }
+    public static void markStatus(String input, ArrayList<Task> Array) throws TaskDoesNotExistException {
+        printLine();
+        String[] instructions = input.split(" ");


Please improve spacing. Use the IDE to do it for you!

okkhoy · 2022-09-19T01:34:39Z

src/main/java/consoleCommands/ConsoleCommands.java

+        System.out.println("  " + Array.get(index-1));
+        printLine();
+    }
+    public static void printList(ArrayList<Task> Array) {


Parameter naming is off convention/standards.
If it is a constant it should be ARRAY, if not it should be array.
Also, a better name would be useful.

okkhoy · 2022-09-19T01:37:28Z

src/main/java/consoleCommands/ConsoleCommands.java

+        System.out.println("Now you have " + Array.size() + " tasks in the list.");
+        printLine();
+    }
+    public static void addTask(String input, ArrayList<Task> Array) throws InvalidCommandException, InvalidArgumentsException, NotEnoughArgumentsException {


this line seems particularly long. try to wrap it

okkhoy · 2022-09-19T01:37:48Z

src/main/java/consoleCommands/ConsoleCommands.java

+        }
+        else if (instructions[0].equals(COMMAND_TODO)) {


coding standard violation here.

okkhoy · 2022-09-19T01:38:54Z

src/main/java/consoleCommands/FileCommands.java

+    public static final String TRUE = "1";
+    public static final String FALSE = "0";


These variable names could trip the reader/maintainer, given that there is already keywords of the same name

okkhoy · 2022-09-19T01:39:29Z

src/main/java/task/Deadline.java

+package task;
+
+public class Deadline extends Task {
+    protected String by;


Why is this protected?
Are you inheriting anything else from deadline to make use of this field?

okkhoy · 2022-09-19T01:40:42Z

src/main/java/task/Task.java

+public class Task {
+    protected String description;
+    public boolean isDone;
+    public Task(String description) { //creating new object


Errrm... that is what a constructor is for.
Please remove that redundant comment.

Update Duke.java

Edits done to code style after checkstyle Added comments for storage > readFromFile Edited UG

- Fixed bugs with date in event and deadline - Fixed bugs with find command - Fixed bugs with list command - Minor changes to naming conventions and documentation - Updated UG to fit new changes - Added new exception DateParseException

jeyvia added 4 commits August 19, 2022 13:18

Level-0

59bd46b

Level-1

4db59bc

Level-2

293e773

Level-3

4ba9e68

jeyvia changed the title ~~Completed Levels-1,2,3~~ [Javier Ong Ding Quan] IP Aug 30, 2022

LokQiJun reviewed Aug 31, 2022

View reviewed changes

jingwei55 reviewed Aug 31, 2022

View reviewed changes

jeyvia and others added 11 commits September 1, 2022 02:09

Level-4

a771a6e

Updating tags

28adf88

testing

2631c81

Merge branch 'branch-Level-5'

a6ea4a6

9 sep commit

e0b44a9

Not complete with exceptions

Merge branch 'branch-Level-5'

dc838dd

fixes

70de262

Delete Task.java

9d5b1f0

Level-5

7574943

Level-6

0ffa7a5

Level-7

949046b

okkhoy reviewed Sep 19, 2022

View reviewed changes

jeyvia and others added 11 commits September 25, 2022 15:37

iP edits

87c489f

Level-9

227362e

A-MoreOOP

81773c3

Level-8

e25db8d

A-JavaDoc

d173661

A-UserGuide

101b4d0

Update Duke.java

b9ef555

Merge pull request #1 from jeyvia/branch-Level-8

15185ef

Update Duke.java

Final changes to iP

ea24761

Update Storage.java

dafa2da

Added equalsIgnoreCase() for commands

f5f44fd

jeyvia added 3 commits September 28, 2022 15:05

Checkstyle edits & comments

c1ca0f8

Edits done to code style after checkstyle Added comments for storage > readFromFile Edited UG

Bug fixes, final changes and UG update

d36d7a6

- Fixed bugs with date in event and deadline - Fixed bugs with find command - Fixed bugs with list command - Minor changes to naming conventions and documentation - Updated UG to fit new changes - Added new exception DateParseException

Update DateParseException.java

4408d97

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Javier Ong Ding Quan] IP #64

[Javier Ong Ding Quan] IP #64

jeyvia commented Aug 30, 2022

LokQiJun left a comment

LokQiJun Aug 31, 2022

LokQiJun Aug 31, 2022

LokQiJun Aug 31, 2022

LokQiJun Aug 31, 2022

jingwei55 left a comment

jingwei55 Aug 31, 2022

jingwei55 Aug 31, 2022

jingwei55 Aug 31, 2022

jingwei55 Aug 31, 2022

okkhoy left a comment

okkhoy Sep 19, 2022

okkhoy Sep 19, 2022

jeyvia Sep 19, 2022

okkhoy Sep 19, 2022

okkhoy Sep 19, 2022

okkhoy Sep 19, 2022

okkhoy Sep 19, 2022

okkhoy Sep 19, 2022

okkhoy Sep 19, 2022

okkhoy Sep 19, 2022

		@@ -0,0 +1,57 @@
		public class TaskList {
		Task[] list = new Task[100];

		int number = Integer.parseInt(instructions[1]);
		list[number-1].isDone = false;

		@@ -1,10 +1,83 @@
		import consoleCommands.ConsoleCommands;
		import exception.*;

		public static final String TRUE = "1";
		public static final String FALSE = "0";

[Javier Ong Ding Quan] IP #64

Are you sure you want to change the base?

[Javier Ong Ding Quan] IP #64

Conversation

jeyvia commented Aug 30, 2022

LokQiJun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jingwei55 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okkhoy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment