[Bian Rui] iP #60
Open
[Bian Rui] iP #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrenechua
reviewed
Sep 1, 2022
src/main/java/Storage.java
Outdated
| import java.util.Arrays; | ||
|
|
||
| public class Storage { | ||
| private static final String IDLE_MESSAGE = "Nothing happened QaQ"; |
There was a problem hiding this comment.
good use of constants! makes the code very neat and readable
src/main/java/Task.java
Outdated
| public class Task { | ||
| protected String description; | ||
| protected boolean isDone; | ||
| protected static int TIME_SEPARATOR_LENGTH = 5; //length of separator from input, eg: /at:, /by: |
src/main/java/Storage.java
Outdated
| */ | ||
| public void execute(String cmd) { | ||
| String[] words = cmd.split(COMMAND_SEPARATOR); | ||
| switch (words[0]) { |
| @@ -0,0 +1,30 @@ | |||
| public class Task { | |||
| protected String description; | |||
| protected boolean isDone; | |||
Than-Duc-Huy
reviewed
Sep 1, 2022
src/main/java/Event.java
Outdated
|
|
||
| @Override | ||
| public String getStatusIcon() { | ||
| String statusIcon = "[E]"; |
There was a problem hiding this comment.
Use your predefined constant EVENT_MARK
hughjazzman
reviewed
Sep 12, 2022
src/main/java/FormatChecker.java
Outdated
| int TIME_IDENTIFIER_LENGTH = 5; | ||
|
|
||
| static void checkNullString(String string) throws WrongCommandFormatException { | ||
| if(string.replaceAll("\\s+","").equals("")) { |
There was a problem hiding this comment.
Just a space!
Suggested change
| if(string.replaceAll("\\s+","").equals("")) { | |
| if (string.replaceAll("\\s+","").equals("")) { |
src/main/java/Storage.java
Outdated
|
|
||
| try { | ||
| if (cmds[0].equalsIgnoreCase(COMMAND_MARK)) { | ||
| list[Integer.parseInt(cmds[1]) - 1].setIsDone(true); |
There was a problem hiding this comment.
Consider breaking this up to avoid complicated expressions.
src/main/java/Todo.java
Outdated
| private static final String TODO_MARK = "[T]"; | ||
|
|
||
| /** | ||
| * Deafult constructor for a Todo instance |
There was a problem hiding this comment.
Mini typo.
Suggested change
| * Deafult constructor for a Todo instance | |
| * Default constructor for a Todo instance |
added 5 commits
September 14, 2022 21:30
* branch-Level-7: Add load and save file feature # Conflicts: # src/main/java/Storage.java
hughjazzman
reviewed
Sep 18, 2022
|
|
||
| @Override | ||
| public String getTime() { | ||
| return this.time; |
There was a problem hiding this comment.
Perhaps you can avoid the unnecessary use of this.
Suggested change
| return this.time; | |
| return time; |
https://se-education.org/guides/conventions/java/index.html#variables
src/main/java/FileIO.java
Outdated
| } | ||
|
|
||
| static void writeFile(ArrayList<Task> Tasks) throws IOException { | ||
| FileWriter fw = new FileWriter("/Users/bromine/ip/Saves/Tasks"); |
There was a problem hiding this comment.
Seems the Path is repeated twice, could it be better as a constant?
update find method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.