Shen Zheqi #59

zheqis12138 · 2022-08-29T17:01:22Z

No description provided.

ChengYoghurt

Goooooooooood WOWWWWWW

ChengYoghurt · 2022-09-02T03:42:28Z

src/main/java/Duke.java

-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+        printWelcomeMessage();
+        Task[] taskLists = new Task[100];


Plz avoid using the magic number~

ChengYoghurt · 2022-09-02T03:46:06Z

src/main/java/Duke.java

+
+        while(!userInput.equals("bye")){
+            String[] userInputSplit = userInput.split(" ");
+            switch(userInputSplit[0]){


Good job on using correct indent on Switch!

ChengYoghurt · 2022-09-02T03:51:19Z

src/main/java/Task.java

@@ -0,0 +1,26 @@
+public class Task {
+    private boolean isDone;
+    String description;


Yea can add the public label on it~

ChengYoghurt · 2022-09-02T03:51:48Z

src/main/java/Task.java

+    String description;
+    public static int numOfTasks = 0;
+
+    public Task (String description){


Good getter toc control the access to attr!

Yikai-Cao

LGTM, almost. Just a few nits to fix.

Yikai-Cao · 2022-09-02T04:15:17Z

src/main/java/Duke.java

+
+        String userInput = getUserInput();
+
+        while(!userInput.equals("bye")){


Explicit use of switch

Yikai-Cao · 2022-09-02T04:16:12Z

src/main/java/Duke.java

+
+    public static void printEchoInput(String userInput){
+        String echoInput =
+                "    ____________________________________________________________\n"


Maybe you can separate the print of the line

Yikai-Cao · 2022-09-02T04:16:52Z

src/main/java/Duke.java

+        System.out.println("    ____________________________________________________________");
+        System.out.println("     Here are the tasks in your list:");
+        String isDoneNotation;
+        for (int i=0; i<count; i++){


i = 0; i < count , maybe more spaces

Yikai-Cao · 2022-09-02T04:17:32Z

src/main/java/Duke.java

+    public static void printWelcomeMessage() {
+        String welcomeMessage =
+                "    ____________________________________________________________\n"
+                + "     Hello! I'm Duke\n"


Maybe using System.lineSeparator() is better than \n

mathanmahe

Good job! I have highlighted some coding standard violations and improvements to code quality.

mathanmahe · 2022-09-18T02:57:32Z

src/main/java/Duke.java

    }
+
+    private static void deleteTask(ArrayList<Task> taskLists, int deleteIndex) {
+        System.out.println("    ____________________________________________________________");


Try to avoid magic strings, if there are strings like this that need to be reused, it is good to create a constant called DIVIDER and reusing it at every occurence to improve readability.

Code Quality Guideline: Avoid Magic Literals

mathanmahe · 2022-09-18T02:58:44Z

src/main/java/Duke.java

+        System.out.println("     Noted. I've removed this task:");
+        System.out.println(String.format("       %s", taskLists.get(deleteIndex).toString()));
+        taskLists.remove(deleteIndex);
+        Task.numOfTasks --;


No need to leave a space for post Increments as per the Java coding standard

mathanmahe · 2022-09-18T03:00:58Z

src/main/java/Duke.java

+        Task.numOfTasks ++;
+        printEchoInput(newEvent);
+    }
+    // add exception


This seems like a reminder to yourself to add exceptions. Avoid personal comments that are private notes to yourself, instead comments should be written to the reader to improve readability. If not necessary here, can remove it altogether.

Code quality guideline: Write to the Reader

mathanmahe · 2022-09-18T03:02:32Z

src/main/java/Duke.java

+        System.out.println(byeMessage);
+    }
+
+    // replace count


Write comments to the reader. Can remove unnecessary comments if they are not to the reader.

Coding Standard Guideline: Comment minimally, but sufficiently

mathanmahe · 2022-09-18T03:05:00Z

src/main/java/Duke.java

+
+        String userInput = getUserInput();
+
+        while(!userInput.equals("bye")){


Since you have already declared the constant string BYE, can be reused here

mathanmahe · 2022-09-18T03:07:08Z

src/main/java/Duke.java

+                deleteTask(taskLists, deleteIndex);
+                break;
+
+                default:


Default should have the same indent level as your other cases in switch, as per the Java coding standard.

mathanmahe · 2022-09-18T03:07:52Z

src/main/java/Duke.java

+        printWelcomeMessage();
+        ArrayList<Task> taskLists = new ArrayList<Task>();
+
+


Avoid long methods, try to break down methods longer than 30 lines of code into smaller methods.

Code Quality Guideline: Avoid Long Methods

Branch level 9

…-JavaDoc

Branch a java doc

ZHEQI SHEN added 4 commits August 26, 2022 13:44

Level-0

b76cb0d

Echos commands entered by the user

aed9a47

Add, List

152c991

Mark as Done

a54482c

ChengYoghurt reviewed Sep 2, 2022

View reviewed changes

Yikai-Cao reviewed Sep 2, 2022

View reviewed changes

ZHEQI SHEN added 10 commits September 6, 2022 01:55

ToDos, Events, Deadlines

aa1c3ef

Code quality

4db3198

Handle Errors

18197b3

delete tasks

a45536c

Delete

102bac6

Save

0e67341

Merge branch 'branch-Level-6'

56457ac

Merge branch 'branch-Level-7'

0201672

add exceptions

d5765a9

Merge branch 'branch-Level-5'

a85507c

mathanmahe reviewed Sep 18, 2022

View reviewed changes

ZHEQI SHEN and others added 13 commits September 26, 2022 16:40

Read and Save

903a7cf

Jar

26ca4d2

try to implement more OOP

b46cc81

finish MoreOOP

dcefdd6

Find

b165da1

Java Doc

eb3ea33

bug fixed

e50a633

add find features

2ec514f

update java doc

89d8414

Merge pull request #1 from zheqis12138/branch-Level-9

1749807

Branch level 9

Merge commit '174980756584400a11865960d37a94c525588c48' into branch-A…

502caa5

…-JavaDoc

Merge pull request #2 from zheqis12138/branch-A-JavaDoc

5b7b9c3

Branch a java doc

clear content file

e3a5721

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shen Zheqi #59

Shen Zheqi #59

zheqis12138 commented Aug 29, 2022

ChengYoghurt left a comment

ChengYoghurt Sep 2, 2022

ChengYoghurt Sep 2, 2022

ChengYoghurt Sep 2, 2022

ChengYoghurt Sep 2, 2022

Yikai-Cao left a comment

Yikai-Cao Sep 2, 2022

Yikai-Cao Sep 2, 2022

Yikai-Cao Sep 2, 2022

Yikai-Cao Sep 2, 2022

mathanmahe left a comment

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022

mathanmahe Sep 18, 2022


		String userInput = getUserInput();

		while(!userInput.equals("bye")){

		printWelcomeMessage();
		ArrayList<Task> taskLists = new ArrayList<Task>();

Shen Zheqi #59

Are you sure you want to change the base?

Shen Zheqi #59

Conversation

zheqis12138 commented Aug 29, 2022

ChengYoghurt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yikai-Cao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mathanmahe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment