-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103-T17-1] TeamBuilder #78
Open
ChickenChiang
wants to merge
459
commits into
nus-cs2103-AY2223S2:master
Choose a base branch
from
AY2223S2-CS2103T-T17-1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103-T17-1] TeamBuilder #78
ChickenChiang
wants to merge
459
commits into
nus-cs2103-AY2223S2:master
from
AY2223S2-CS2103T-T17-1:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
============================================
+ Coverage 72.15% 72.34% +0.18%
- Complexity 399 606 +207
============================================
Files 70 95 +25
Lines 1232 1985 +753
Branches 125 229 +104
============================================
+ Hits 889 1436 +547
- Misses 311 459 +148
- Partials 32 90 +58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
2 tasks
AddCommandParser now does not throw exception if the major prefix is missing.
Optional major
UnqieteamList class directly mirrors the behaviour of UniquePersonList. Likewise, the exceptions thrown are just the mirrored exceptions for persons.
…amBuilder To maintain a UniqueTeamList in the TeamBuidler model, methods are created to maintain the UniqueTeamList
This method is needed for TeamBuilder model to check if there are duplicate teams. Teams are considered duplicates if they have the same name.
Added methods for maintaining Team list
Teamlist and associated commands
# Conflicts: Removed team tags on the sample data # src/main/java/teambuilder/model/util/SampleDataUtil.java
# Conflicts: # src/main/java/teambuilder/model/Model.java # src/main/java/teambuilder/model/ModelManager.java # src/main/java/teambuilder/model/TeamBuilder.java # src/test/java/teambuilder/logic/commands/AddCommandTest.java # src/test/java/teambuilder/logic/commands/RedoCommandIntegrationTest.java # src/test/java/teambuilder/logic/commands/UndoCommandTest.java # src/test/java/teambuilder/model/TeamBuilderTest.java
…into Merge # Conflicts: # src/main/java/teambuilder/model/util/SampleDataUtil.java
# Conflicts: # src/main/java/teambuilder/model/Model.java # src/main/java/teambuilder/model/ModelManager.java # src/main/java/teambuilder/model/TeamBuilder.java # src/main/java/teambuilder/model/team/UniqueTeamList.java # src/main/java/teambuilder/model/team/exceptions/TeamNotFoundException.java # src/test/java/teambuilder/logic/commands/AddCommandTest.java # src/test/java/teambuilder/logic/commands/RedoCommandIntegrationTest.java # src/test/java/teambuilder/logic/commands/UndoCommandTest.java # src/test/java/teambuilder/model/TeamBuilderTest.java
Ensure that TeamName is converted to lower case before applying check
TeamName and person Name should both be equivalent regardless of casing and trailing white spaces
Fix broken links
Update DG for Jiarui's part
Add Appendix: Effort to DG
Update william's ppp
- Specification for sort command - Change screen shots for UG
Fix DG diagrams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TeamBuilder is a contact list that helps students and professionals to find people in their contacts to build teams with, for competitions and projects alike. TeamBuilder can organise contacts and add flags such that the team formation process is much faster