-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tan Gee Teng] iP #281
Open
geetengtan
wants to merge
45
commits into
nus-cs2103-AY2122S2:master
Choose a base branch
from
geetengtan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Tan Gee Teng] iP #281
Changes from 3 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
d839859
Add Gradle support
ba88212
level-1
geetengtan 8278dd9
level-1
geetengtan aae4682
level-2
geetengtan 753acd7
Mark as Done
geetengtan b696fe4
ToDos, Events, Deadlines
geetengtan 5df357a
Automated Text UI Testing
geetengtan b839e06
Handle Errors
geetengtan 621bb3a
Delete
geetengtan 7d77ec9
Simplify code
geetengtan 8e7d18f
Add save feature
geetengtan 786bcef
Add date time formatting
geetengtan a261db1
test branching
geetengtan 2ef0d93
Merge branch 'branch-Level-7'
geetengtan 8bcf1bf
Merge branch 'branch-Level-8'
geetengtan b0ee8f3
Fix bug for merging
geetengtan ed76196
Use More OOP
geetengtan de4db61
Organize into Packages
geetengtan ed074ac
Fix bugs and Add JUnit Test
geetengtan 8b73153
Merge remote-tracking branch 'origin/add-gradle-support'
geetengtan c87aecb
Fix Gradle bugs and add jar
geetengtan 6c080c7
Add JavaDoc
geetengtan 50bd80a
Fix bugs and add Find Feature
geetengtan dca73b3
Fix gradle properties
geetengtan d6dbbd6
Follow Coding Standard for 2103
geetengtan 1337e0b
Merge branch 'branch-Level-9'
geetengtan 5050475
Merge branch 'branch-A-JavaDoc'
geetengtan 558c6e3
Improve code readability
geetengtan e3a7aca
GUI
geetengtan 8ae7ca4
Add Pictures
geetengtan 1c370ee
Improve code quality
geetengtan 93993c4
Find command: make matching case insensitive
geetengtan 89ea9c9
Improve code quality
geetengtan 40f3d93
Add assertions
geetengtan cf1bff7
Merge branch 'branch-A-CodeQuality'
geetengtan 1033df2
Add Notes feature
geetengtan f84d529
Add HELP feature
geetengtan e4fb4ce
Change UI and update README
geetengtan 0da1a0a
update README and CodeQuality
geetengtan 0e4e193
fix storage bug
geetengtan 244524e
Merge pull request #2 from geetengtan/branch-MergingPR
geetengtan 49c5706
made storage cross-platform
geetengtan 1f7c66f
fix javafx version
geetengtan 01d3105
fix fxml version
geetengtan f6b5d37
update README and UG
geetengtan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
T#false#borrow book | ||
T#true#borrow book | ||
D#false#return book #2021-02-02 | ||
T#false#play |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
#Wed Feb 02 12:10:36 MYT 2022 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.1-bin.zip | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-6.2-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,11 @@ public class Ui { | |
private static final int MARK = 4; | ||
private static final int UNMARK = 5; | ||
private static final int DELETE = 6; | ||
|
||
private static final int FIND = 7; | ||
|
||
/** | ||
* Prints an error message for failure in loading files | ||
*/ | ||
public void showLoadingError() { | ||
System.out.println("Failed to retrieve data from storage"); | ||
} | ||
|
@@ -40,6 +44,9 @@ public void nextInput(String input, TaskList tasks) { | |
case DELETE: | ||
myPrint(tasks.delete(Parser.getIndex(input))); | ||
break; | ||
case FIND: | ||
myPrint(tasks.find(Parser.getDescription(input))); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it will be better to change the myprint() method name to something that would explain the function better |
||
break; | ||
} | ||
} catch (DukeException e) { | ||
myPrint(e.toString()); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boolean variable should use a prefix such as is, has, was.