[W5.7][F11-2] Teo Wei Zheng #458
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the tags for each person do not seem to serve any purpose. However, the tags can be a useful and flexible way for filtering out certain types of people. Let's add a new command to allow users to search people by their tags.
The new command for finding people by tag is not a recognised command yet. This commit adds the option "findtag" into the CLI. At this stage, invoking the "findtag" command with any number of arguments will only print a test message.
The "findtag" command is currently recognised but only prints a test message as of now. This commit adds in the functionality of this function. Users may now use the "findtag" command and provide multiple tags to search for people with the given tags.
The command "findtag" has been implemented but not tested yet. This commit adds several test cases to ensure that the command functions properly.
The "findtag" command has been implemented but lacks a proper unit test. Bugs may be present that may not be discoverable by users. This commit adds several JUnit tests to ensure the correctness of this command.
The command "findtag" has been implemented but the user guide has not been updated. Users may be unaware of the existence of this command or may not understand how to use it. The user guide has been updated to teach users about this command.
|
good job!!!!!!! great effort in creating test cases too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new command, "findtag", to search for people using their tags. This was added as tags do not serve much purpose currently and adding this command would lead to more purposeful use of the tags.