Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W5.7][F10-1]De Jesus Joshua Robert #447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[W5.7][F10-1]De Jesus Joshua Robert #447

wants to merge 2 commits into from

Conversation

jroberts91
Copy link

No description provided.

@wn
Copy link

wn commented Sep 13, 2018

Added Edit Person command - Commit messages should be in present tense.

Copy link

@jlks96 jlks96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done on completing the LO. Maybe you can update the help command as well to show the newly added edit command?

* @throws IllegalValueException if any of the raw values are invalid
*/
public EditCommand(String name,
String phone, boolean isPhonePrivate,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation for wrapped lines should be 8 spaces <== from coding standard provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants