[T6A1][W10-B3] YinaToh #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwkchia
reviewed
Mar 7, 2017
There was a problem hiding this comment.
As we are now using StorageStub in LogicTest, we need not test the correctness of StorageFile when we test the Logic class. There is a line in the assertCommandBehavior method that checks for the contents on the disk with the contents in memory; this should be removed.
| @@ -45,11 +46,11 @@ void setAddressBook(AddressBook addressBook){ | |||
| * Creates the StorageFile object based on the user specified path (if any) or the default storage path. | |||
| * @throws StorageFile.InvalidStorageFilePathException if the target file path is incorrect. | |||
| */ | |||
| private StorageFile initializeStorage() throws StorageFile.InvalidStorageFilePathException { | |||
| private Storage initializeStorage() throws Storage.InvalidStoragePathException { | |||
| return new StorageFile(); | |||
There was a problem hiding this comment.
The creating of StorageFile is a little unfortunate, but nonetheless has to be done. The original design already violates OCP. Fyi, an issue has been raised regarding this se-edu/addressbook-level3#75.
That aside, a good job in applying DIP 👍
| import seedu.addressbook.data.AddressBook; | ||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
|
|
||
| public abstract class Storage { |
| public InvalidStoragePathException(String message) { | ||
| super(message); | ||
| } | ||
| } |
| } | ||
| } | ||
|
|
||
| public abstract void save(AddressBook addressBook) throws StorageOperationException; |
| @Override | ||
| public AddressBook load() throws StorageOperationException { | ||
| // TODO Auto-generated method stub | ||
| return null; |
There was a problem hiding this comment.
👍...though it will be better to have StorageStub in the test directory, and careful with indentation
|
Ack by closing PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.