{To,From}Field for NominalDiffTime #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredefox
force-pushed
the
master
branch
3 times, most recently
from
15877e2 to
6df2a16
Compare
This is my first time ever doing data-type generic programming, so please review this carefully. I conferred with the documentation in base[1] and I also looked at the analoguous definition in the package `binary`[2]. It was surprisingly easy to implement, but perhaps it should be tested some more before merging in. I've just quickly tested it with the code-base I'm working on. Note that it the current implementation can only derive the generic instance for product-types (not sum-types). [1]: http://hackage.haskell.org/package/base-4.12.0.0/docs/GHC-Generics.html#g:10 [2]: http://hackage.haskell.org/package/binary
This may be less of an interesting change...
|
Any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.