refactor: use mutex for file determination #1113

Lorilatschki · 2023-08-03T08:10:19Z

Ensure the file determination process is aware of multiple test runs in different processes by using a mutex for the assembly path

…up a custom result file name rather than the name of the assembly to be tested

…test runs in different processes by using a mutex for the assembly path

OsirisTerje · 2023-08-03T11:29:49Z

@Lorilatschki Two tests failing :-)

Lorilatschki · 2023-08-03T12:59:59Z

@OsirisTerje I have seen it but I don't know why. I tried to debug the test locally (it is only enabled for net462) but I cannot run it inside my VS2022. It always says the following:

Processing C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnit3AdapterExternalTests\bin\Debug\net462\NUnit.VisualStudio.TestAdapter.ExternalTests.dll
Workdir set to: C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnit3AdapterExternalTests\bin\Debug\net462
Execution engine run time with filter length 9 :Elapsed: 00:00:00.00
Filter: <filter/>
Discovery/Processing/Converting: :Elapsed: 00:00:00.00
Discovered 0 test cases
Processing C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnitTestAdapterTests\bin\Debug\net462\NUnit.VisualStudio.TestAdapter.Tests.dll
Workdir set to: C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnitTestAdapterTests\bin\Debug\net462
Execution engine run time with filter length 9 :Elapsed: 00:00:00.28
Filter: <filter/>
NUnit failed to load C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnitTestAdapterTests\bin\Debug\net462\NUnit.VisualStudio.TestAdapter.Tests.dll
NUnit Adapter 4.5.0.0: Test discovery complete
No test is available in C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\empty-assembly\bin\Debug\net462\empty-assembly.dll C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\mock-assembly\bin\Debug\net462\mock-assembly.dll C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnit3AdapterExternalTests\bin\Debug\net462\NUnit.VisualStudio.TestAdapter.ExternalTests.dll C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnitTestAdapterTests\bin\Debug\net462\NUnit.VisualStudio.TestAdapter.Tests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Could not find testhost
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting.DotnetTestHostManager.GetTestHostProcessStartInfo(IEnumerable`1 sources, IDictionary`2 environmentVariables, TestRunnerConnectionInfo connectionInfo)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, String runSettings)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.InitializeDiscovery(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler, Boolean skipDefaultAdapters)
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Could not find testhost
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting.DotnetTestHostManager.GetTestHostProcessStartInfo(IEnumerable`1 sources, IDictionary`2 environmentVariables, TestRunnerConnectionInfo connectionInfo)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, String runSettings)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.InitializeDiscovery(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler, Boolean skipDefaultAdapters)
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Could not find testhost
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting.DotnetTestHostManager.GetTestHostProcessStartInfo(IEnumerable`1 sources, IDictionary`2 environmentVariables, TestRunnerConnectionInfo connectionInfo)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyOperationManager.SetupChannel(IEnumerable`1 sources, String runSettings)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.InitializeDiscovery(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler, Boolean skipDefaultAdapters)
System.InvalidOperationException: The provided manager was not found in any slot.
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ParallelOperationManager`3.ClearCompletedSlot(TManager completedManager)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ParallelOperationManager`3.RunNextWork(TManager completedManager)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelProxyDiscoveryManager.HandlePartialDiscoveryComplete(IProxyDiscoveryManager proxyDiscoveryManager, Int64 totalTests, IEnumerable`1 lastChunk, Boolean isAborted)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelDiscoveryEventsHandler.HandleDiscoveryComplete(DiscoveryCompleteEventArgs discoveryCompleteEventArgs, IEnumerable`1 lastChunk)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.InitializeDiscovery(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler, Boolean skipDefaultAdapters)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)
System.AggregateException: One or more errors occurred. ---> System.InvalidOperationException: The provided manager was not found in any slot.
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ParallelOperationManager`3.ClearCompletedSlot(TManager completedManager)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ParallelOperationManager`3.RunNextWork(TManager completedManager)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelProxyDiscoveryManager.HandlePartialDiscoveryComplete(IProxyDiscoveryManager proxyDiscoveryManager, Int64 totalTests, IEnumerable`1 lastChunk, Boolean isAborted)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelDiscoveryEventsHandler.HandleDiscoveryComplete(DiscoveryCompleteEventArgs discoveryCompleteEventArgs, IEnumerable`1 lastChunk)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelProxyDiscoveryManager.<>c__DisplayClass27_0.<DiscoverTestsOnConcurrentManager>b__0()
   at System.Threading.Tasks.Task.Execute()
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.InvalidOperationException: The provided manager was not found in any slot.
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ParallelOperationManager`3.ClearCompletedSlot(TManager completedManager)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ParallelOperationManager`3.RunNextWork(TManager completedManager)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelProxyDiscoveryManager.HandlePartialDiscoveryComplete(IProxyDiscoveryManager proxyDiscoveryManager, Int64 totalTests, IEnumerable`1 lastChunk, Boolean isAborted)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelDiscoveryEventsHandler.HandleDiscoveryComplete(DiscoveryCompleteEventArgs discoveryCompleteEventArgs, IEnumerable`1 lastChunk)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.ProxyDiscoveryManager.DiscoverTests(DiscoveryCriteria discoveryCriteria, ITestDiscoveryEventsHandler2 eventHandler)
   at Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel.ParallelProxyDiscoveryManager.<>c__DisplayClass27_0.<DiscoverTestsOnConcurrentManager>b__0()
   at System.Threading.Tasks.Task.Execute()<---

Any idea what I am doing wrong?

Running dotnet test --framework net462 on a command line doesn't work either.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
No test is available in C:\Users\xxx\source\repos\github\nunit3-vs-adapter\src\NUnitTestAdapterTests\bin\Debug\net462\NUnit.VisualStudio.TestAdapter.Tests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

Additionally, path to test adapters can be specified using /TestAdapterPath command. Example  /TestAdapterPath:<pathToCustomAdapters>.

OsirisTerje · 2023-08-03T13:21:38Z

I don't think you're doing anything wrong. I've got the same message from time to time lately. I wonder if this is some bug in the testhost or some related component. If you tro to run it from the command line, using dotnet test I believe it will work.

SORRY: Didnt see your last lines....

Try to run: build --target=Test

About VS: I clean the solution, sometimes even delete all bin and obj files and even the -vs folder, then it works. In some cases I change the targetframeworks to ONLY be one specific framework. Not sure what is wrong here, but I have seen it on other solutions as well.

Lorilatschki · 2023-08-03T13:40:17Z

Try to run: build --target=Test

This worked! I found the issue, in that 2 tests the assemblyPath is null and creating a mutex with a name equals null isn't allowed. I have adapted the name determination.

…or empty

Lorilatschki · 2023-08-03T15:02:03Z

@OsirisTerje locally the tests are passing with my last commit. Can you please double check it on your end?

OsirisTerje · 2023-08-03T15:28:48Z

The build is still failing with the same errors, files not found.

OsirisTerje · 2023-08-03T16:27:33Z

I cloned your PR repo, and on net core there are no errors. And net462 doesnt run at all..... in VS that is.
Using the build --target=Test I get 2 errors with .net fw from the tests ThatTestOutputXmlHasBeenCreatedBelowAssemblyFolder and ThatTestOutputXmlHasBeenAtWorkDirLocation. These two tests only exist for net fw.

I tested the master branch, and all tests there works, so the tests are actually failing.

OsirisTerje · 2023-08-03T16:48:47Z

Cool! That last commit/change did the trick !!

OsirisTerje · 2023-08-03T17:21:16Z

@Lorilatschki Do you fix the conflict too, and then we merge

OsirisTerje · 2023-08-03T17:49:17Z

@Lorilatschki Some merge stuff, it seems:
Error: D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\NUnitEngineAdapter.cs(203,23): error CS0111: Type 'NUnitEngineAdapter' already defines a member called 'GetTestOutputFileName' with the same parameter types [D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnit.TestAdapter.csproj::TargetFramework=net462] Error: D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\NUnitEngineAdapter.cs(203,23): error CS0111: Type 'NUnitEngineAdapter' already defines a member called 'GetTestOutputFileName' with the same parameter types [D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnit.TestAdapter.csproj::TargetFramework=netcoreapp3.1]

Lorilatschki · 2023-08-03T18:07:15Z

@Lorilatschki Some merge stuff, it seems:
Error: D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\NUnitEngineAdapter.cs(203,23): error CS0111: Type 'NUnitEngineAdapter' already defines a member called 'GetTestOutputFileName' with the same parameter types [D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnit.TestAdapter.csproj::TargetFramework=net462] Error: D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnitEngine\NUnitEngineAdapter.cs(203,23): error CS0111: Type 'NUnitEngineAdapter' already defines a member called 'GetTestOutputFileName' with the same parameter types [D:\a\nunit3-vs-adapter\nunit3-vs-adapter\src\NUnitTestAdapter\NUnit.TestAdapter.csproj::TargetFramework=netcoreapp3.1]

I will fix it.

Lorilatschki · 2023-08-03T19:56:11Z

@OsirisTerje merge conflict is solved.

Lorilatschki added 2 commits August 3, 2023 09:45

feat: enable TestOutputXmlFileNameWithoutExtension run setting to set…

8f02e4b

…up a custom result file name rather than the name of the assembly to be tested

refactor: ensure the file determination process is aware of multiple …

e2b5c6a

…test runs in different processes by using a mutex for the assembly path

Lorilatschki mentioned this pull request Aug 3, 2023

NUnit.Console.exe sometimes returns with -100 (SocketException) nunit/nunit-console#1276

Open

chore: adjust name to TestOutputXmlFileName

7e63612

chore: take care of correct mutex name in case assembly path is null …

42c79a8

…or empty

chore: use name of file instead of path

90f2999

Lorilatschki and others added 2 commits August 3, 2023 19:40

merge: merge from master

62a0841

Merge branch 'master' into feat/mutex_for_filecreation

537878c

chore: fix merge issue

f78b30d

OsirisTerje merged commit f3b5c9c into nunit:master Aug 3, 2023
3 checks passed

OsirisTerje mentioned this pull request Aug 3, 2023

Use mutex for file determination in TestOutputXml #1115

Closed

Lorilatschki deleted the feat/mutex_for_filecreation branch August 3, 2023 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: use mutex for file determination #1113

refactor: use mutex for file determination #1113

Lorilatschki commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023

Lorilatschki commented Aug 3, 2023 •

edited

Loading

OsirisTerje commented Aug 3, 2023 •

edited

Loading

Lorilatschki commented Aug 3, 2023

Lorilatschki commented Aug 3, 2023 •

edited

Loading

OsirisTerje commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023 •

edited

Loading

OsirisTerje commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023 •

edited

Loading

Lorilatschki commented Aug 3, 2023 •

edited

Loading

Lorilatschki commented Aug 3, 2023

refactor: use mutex for file determination #1113

refactor: use mutex for file determination #1113

Conversation

Lorilatschki commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023

Lorilatschki commented Aug 3, 2023 • edited Loading

OsirisTerje commented Aug 3, 2023 • edited Loading

Lorilatschki commented Aug 3, 2023

Lorilatschki commented Aug 3, 2023 • edited Loading

OsirisTerje commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023 • edited Loading

OsirisTerje commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023

OsirisTerje commented Aug 3, 2023 • edited Loading

Lorilatschki commented Aug 3, 2023 • edited Loading

Lorilatschki commented Aug 3, 2023

Lorilatschki commented Aug 3, 2023 •

edited

Loading

OsirisTerje commented Aug 3, 2023 •

edited

Loading

Lorilatschki commented Aug 3, 2023 •

edited

Loading

OsirisTerje commented Aug 3, 2023 •

edited

Loading

OsirisTerje commented Aug 3, 2023 •

edited

Loading

Lorilatschki commented Aug 3, 2023 •

edited

Loading