v4: Create ITestPackage interface #950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this one. I still think this should be a part of v4, but it's more than I have time to tackle at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919. Addressing this first, as it's blocking #885.
This creates an ITestPackage interface, and moves the TestPackage class to nunit.engine.core.dll. In the longer term vision (#885) - I'd expect ITestPackage to be moving to the "extensions-core" API assembly, which is the primary motivation to bring in a minimal interface rather than keeping the class itself in that assembly.
This leaves us in the slightly ugly interim state where the only way for a runner to create a TestPackage is by first creating a TestEngine through TestEngineActivator. My thinking is that when (if) we address #948 that will be addressed, and we can re-expose the normal TestPackage constructors.