-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turtle enhancements #404
Merged
Merged
Turtle enhancements #404
Commits on Oct 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e80f898 - Browse repository at this point
Copy the full SHA e80f898View commit details -
Configuration menu - View commit details
-
Copy full SHA for b86531c - Browse repository at this point
Copy the full SHA b86531cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef7b349 - Browse repository at this point
Copy the full SHA ef7b349View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9713740 - Browse repository at this point
Copy the full SHA 9713740View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4e2a32 - Browse repository at this point
Copy the full SHA a4e2a32View commit details -
feat: Operational OEIS search bar (numberscope#410)
* refactor: move the OEIS search bar into its own component. * doc: Basic Modfill -> two OEIS-based Specimens in Gallery * feat: Dummy search results that pop up on input * feat: Call a dummy search cmd on input * feat: list of links and labels for search results * feat: Clicking on a result adds it * fix: When you click on link in results don't also add * feat: Actually search the OEIS. * feat: Cache search results and reopen search on click. * ui: Layout and caption changes per design discussions * fix: Never cache OEIS sequences with infinite indices This PR attempts to resolve numberscope#407. I added a half-dozen OEIS sequences as rapidly as I could and didn't get any errors. So hopefully this has squashed the problem, but it's hard to be certain. * fix: Don't update URL until after parameter values have settled In order to be sure that parameter values have their "final" values in the case of an update (e.g., by calling the Paramable validate() method), it is necessary for a cascade of functions to be made async. This commit makes those changes and then awaits the validate() in the user interface, so that the URL won't be updated until all of the consequences of validate() have occurred (which may, for example, involve changing the parameter values, perhaps even the one that originally had its tentative value modified, necessitating the validate() call). Resolves numberscope#403. * ui: show finger cursor over search results * make oeis.org link open new tab * info icon for info in search results * ui: click off list of OEIS search results closes it * fix: Restore sequences adding when you click on them in result list. * fix: Various fixes to OEIS search bar/results per meeting - Return to the OEIS ID being a link but add the Wikipedia "external link" icon - Highlight the description of each sequence as you mouse over it, to provide clue you can click on it (to add as a sequence). The color used is a lightened version of the "primary" Numberscope color. - Display a message when there are no sequences to show as a result of a search. Note this can occur because there are _too many_ matches, or _no_ matches, and there is no way to tell which is the case from the OEIS api response, unfortunately. The message reflects this. - Fixed bug that results were being cached under the wrong search term if the searcher typed more while the search was executing. - Make sure that enter/clicking on magnifier always fires search * fix: Don't make switcher cards for dummy message IDs * fix: Really make sure magnifier puts/keeps search results up; reword message * fix: catch errors in OEIS searching and report a 'soft' failure --------- Co-authored-by: Kate Stange <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7277f2e - Browse repository at this point
Copy the full SHA 7277f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c54ed38 - Browse repository at this point
Copy the full SHA c54ed38View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2b94f6 - Browse repository at this point
Copy the full SHA e2b94f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6772d1e - Browse repository at this point
Copy the full SHA 6772d1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0af1dc - Browse repository at this point
Copy the full SHA c0af1dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c7251 - Browse repository at this point
Copy the full SHA 71c7251View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b63466 - Browse repository at this point
Copy the full SHA 5b63466View commit details -
Configuration menu - View commit details
-
Copy full SHA for 260f96c - Browse repository at this point
Copy the full SHA 260f96cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c6f2e4 - Browse repository at this point
Copy the full SHA 9c6f2e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fac544b - Browse repository at this point
Copy the full SHA fac544bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6230f9a - Browse repository at this point
Copy the full SHA 6230f9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35beb8f - Browse repository at this point
Copy the full SHA 35beb8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5199e00 - Browse repository at this point
Copy the full SHA 5199e00View commit details -
Configuration menu - View commit details
-
Copy full SHA for d44ce57 - Browse repository at this point
Copy the full SHA d44ce57View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea272f0 - Browse repository at this point
Copy the full SHA ea272f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb1a90 - Browse repository at this point
Copy the full SHA ccb1a90View commit details -
Configuration menu - View commit details
-
Copy full SHA for d661f93 - Browse repository at this point
Copy the full SHA d661f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaaf1e1 - Browse repository at this point
Copy the full SHA eaaf1e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30330fb - Browse repository at this point
Copy the full SHA 30330fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40c5db1 - Browse repository at this point
Copy the full SHA 40c5db1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cf48b0 - Browse repository at this point
Copy the full SHA 3cf48b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d448020 - Browse repository at this point
Copy the full SHA d448020View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d4c3f7 - Browse repository at this point
Copy the full SHA 7d4c3f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e844c78 - Browse repository at this point
Copy the full SHA e844c78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cb6390 - Browse repository at this point
Copy the full SHA 0cb6390View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86af707 - Browse repository at this point
Copy the full SHA 86af707View commit details -
Configuration menu - View commit details
-
Copy full SHA for db9dbc3 - Browse repository at this point
Copy the full SHA db9dbc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for eaa1cd6 - Browse repository at this point
Copy the full SHA eaa1cd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69c3e5b - Browse repository at this point
Copy the full SHA 69c3e5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9764f7d - Browse repository at this point
Copy the full SHA 9764f7dView commit details
Commits on Oct 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 03a394c - Browse repository at this point
Copy the full SHA 03a394cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72a317a - Browse repository at this point
Copy the full SHA 72a317aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d3292b - Browse repository at this point
Copy the full SHA 7d3292bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68b055b - Browse repository at this point
Copy the full SHA 68b055bView commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e9065e9 - Browse repository at this point
Copy the full SHA e9065e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbdf790 - Browse repository at this point
Copy the full SHA bbdf790View commit details
Commits on Oct 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 55876f2 - Browse repository at this point
Copy the full SHA 55876f2View commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e43fafe - Browse repository at this point
Copy the full SHA e43fafeView commit details
Commits on Oct 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9f86aca - Browse repository at this point
Copy the full SHA 9f86acaView commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 327220c - Browse repository at this point
Copy the full SHA 327220cView commit details
Commits on Oct 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5c8b48e - Browse repository at this point
Copy the full SHA 5c8b48eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd853e8 - Browse repository at this point
Copy the full SHA fd853e8View commit details -
fix: Reduce multiple reinitialization on page load
Vue reactivity and parameter updating were interacting poorly. This commit protects against this bad interaction in two ways: 1. Only changes to values that have different string forms than the previous value. This ensures, for example, that a reactive value is not modified just because it is not `===` to the apparently "new" value. 2. Changes the `parameterChanged()` method to be called once for each parameter change to `parametersChanged()` so that multiple simultaneous changes are bundled into one call. With these changes, the startup sequence is more predictable. We hope this change will make end-to-end testing significantly more reproducible. Also makes Turtle not restart drawing from the beginning of the path on a resize, since it is now able to redraw the full path so far without difficulty. Also fixes the default value for the `highlight` parameter of FactorFence; the multiple initializations were masking the prior erroneous value.
Configuration menu - View commit details
-
Copy full SHA for 532be7c - Browse repository at this point
Copy the full SHA 532be7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c89e99 - Browse repository at this point
Copy the full SHA 6c89e99View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c511f0 - Browse repository at this point
Copy the full SHA 3c511f0View commit details
Commits on Oct 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for adad8ad - Browse repository at this point
Copy the full SHA adad8adView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5fde82 - Browse repository at this point
Copy the full SHA e5fde82View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.