Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turtle enhancements #404

Merged
merged 52 commits into from
Oct 25, 2024
Merged

Turtle enhancements #404

merged 52 commits into from
Oct 25, 2024

Commits on Oct 13, 2024

  1. fixes

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e80f898 View commit details
    Browse the repository at this point in the history
  2. small details

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    b86531c View commit details
    Browse the repository at this point in the history
  3. minor repair of growth

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ef7b349 View commit details
    Browse the repository at this point in the history
  4. update desc error

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9713740 View commit details
    Browse the repository at this point in the history
  5. bigint error fix

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    a4e2a32 View commit details
    Browse the repository at this point in the history
  6. feat: Operational OEIS search bar (numberscope#410)

    * refactor: move the OEIS search bar into its own component.
    
    * doc: Basic Modfill -> two OEIS-based Specimens in Gallery
    
    * feat: Dummy search results that pop up on input
    
    * feat: Call a dummy search cmd on input
    
    * feat: list of links and labels for search results
    
    * feat: Clicking on a result adds it
    
    * fix: When you click on link in results don't also add
    
    * feat: Actually search the OEIS.
    
    * feat: Cache search results and reopen search on click.
    
    * ui: Layout and caption changes per design discussions
    
    * fix: Never cache OEIS sequences with infinite indices
       This PR attempts to resolve numberscope#407. I added a half-dozen OEIS
       sequences as rapidly as I could and didn't get any errors.
       So hopefully this has squashed the problem, but it's hard to
       be certain.
    
    * fix: Don't update URL until after parameter values have settled
       In order to be sure that parameter values have their "final" values
       in the case of an update (e.g., by calling the Paramable validate()
       method), it is necessary for a cascade of functions to be made async.
       This commit makes those changes and then awaits the validate() in the
       user interface, so that the URL won't be updated until all of the
       consequences of validate() have occurred (which may, for example,
       involve changing the parameter values, perhaps even the one that
       originally had its tentative value modified, necessitating the validate()
       call).
    
       Resolves numberscope#403.
    
    * ui: show finger cursor over search results
    
    * make oeis.org link open new tab
    
    * info icon for info in search results
    
    * ui: click off list of OEIS search results closes it
    
    * fix: Restore sequences adding when you click on them in result list.
    
    * fix: Various fixes to OEIS search bar/results per meeting
    
      - Return to the OEIS ID being a link but add the Wikipedia
        "external link" icon
      - Highlight the description of each sequence as you mouse over it,
        to provide clue you can click on it (to add as a sequence). The
        color used is a lightened version of the "primary" Numberscope color.
      - Display a message when there are no sequences to show as a result
        of a search. Note this can occur because there are _too many_ matches,
        or _no_ matches, and there is no way to tell which is the case from
        the OEIS api response, unfortunately. The message reflects this.
      - Fixed bug that results were being cached under the wrong search term
        if the searcher typed more while the search was executing.
      - Make sure that enter/clicking on magnifier always fires search
    
    * fix: Don't make switcher cards for dummy message IDs
    
    * fix: Really make sure magnifier puts/keeps search results up; reword message
    
    * fix: catch errors in OEIS searching and report a 'soft' failure
    
    ---------
    
    Co-authored-by: Kate Stange <[email protected]>
    gwhitney and katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    7277f2e View commit details
    Browse the repository at this point in the history
  7. add warning system

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c54ed38 View commit details
    Browse the repository at this point in the history
  8. modify displayName

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e2b94f6 View commit details
    Browse the repository at this point in the history
  9. modify displayName

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    6772d1e View commit details
    Browse the repository at this point in the history
  10. reorganize params

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    c0af1dc View commit details
    Browse the repository at this point in the history
  11. first term

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    71c7251 View commit details
    Browse the repository at this point in the history
  12. tweaks

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5b63466 View commit details
    Browse the repository at this point in the history
  13. minor repair of growth

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    260f96c View commit details
    Browse the repository at this point in the history
  14. add warning system

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9c6f2e4 View commit details
    Browse the repository at this point in the history
  15. modify displayName

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    fac544b View commit details
    Browse the repository at this point in the history
  16. reorganize params

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    6230f9a View commit details
    Browse the repository at this point in the history
  17. first term

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    35beb8f View commit details
    Browse the repository at this point in the history
  18. questionable

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5199e00 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    d44ce57 View commit details
    Browse the repository at this point in the history
  20. refreshParams

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ea272f0 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    ccb1a90 View commit details
    Browse the repository at this point in the history
  22. tidying

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d661f93 View commit details
    Browse the repository at this point in the history
  23. small doc addition

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    eaaf1e1 View commit details
    Browse the repository at this point in the history
  24. small doc change

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    30330fb View commit details
    Browse the repository at this point in the history
  25. small doc change

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    40c5db1 View commit details
    Browse the repository at this point in the history
  26. efficieny when not folding

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    3cf48b0 View commit details
    Browse the repository at this point in the history
  27. merge fixes; runs now

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d448020 View commit details
    Browse the repository at this point in the history
  28. math.ts changes

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    7d4c3f7 View commit details
    Browse the repository at this point in the history
  29. only e2e turtle tests fail

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    e844c78 View commit details
    Browse the repository at this point in the history
  30. fix: Don't let Vue mangle cameras

    gwhitney authored and katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    0cb6390 View commit details
    Browse the repository at this point in the history
  31. small fixes

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    86af707 View commit details
    Browse the repository at this point in the history
  32. simplify code

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    db9dbc3 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    eaa1cd6 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    69c3e5b View commit details
    Browse the repository at this point in the history
  35. code cleanup

    katestange committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    9764f7d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. ready to update snapshots

    katestange committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    03a394c View commit details
    Browse the repository at this point in the history
  2. e2e tests

    katestange committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    72a317a View commit details
    Browse the repository at this point in the history
  3. unit test for bigIsFinite

    katestange committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7d3292b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    68b055b View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    e9065e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bbdf790 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    55876f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. stretch, rotate

    katestange committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    e43fafe View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Configuration menu
    Copy the full SHA
    9f86aca View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. add initial position/angle

    katestange committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    327220c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. remove initial state

    katestange committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5c8b48e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd853e8 View commit details
    Browse the repository at this point in the history
  3. fix: Reduce multiple reinitialization on page load

      Vue reactivity and parameter updating were interacting poorly. This commit
      protects against this bad interaction in two ways:
    
      1. Only changes to values that have different string forms than the
         previous value.  This ensures, for example, that a reactive value is not
         modified just because it is not `===` to the apparently "new" value.
      2. Changes the `parameterChanged()` method to be called once for each
         parameter change to `parametersChanged()` so that multiple simultaneous
         changes are bundled into one call.
    
      With these changes, the startup sequence is more predictable. We hope this
      change will make end-to-end testing significantly more reproducible.
    
      Also makes Turtle not restart drawing from the beginning of the path on
      a resize, since it is now able to redraw the full path so far without
      difficulty.
    
      Also fixes the default value for the `highlight` parameter of FactorFence;
      the multiple initializations were masking the prior erroneous value.
    gwhitney committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    532be7c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6c89e99 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3c511f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    adad8ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e5fde82 View commit details
    Browse the repository at this point in the history