-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Switch to pnpm package manager #147
base: main
Are you sure you want to change the base?
Conversation
f5dfa2b
to
4aebf92
Compare
4aebf92
to
7785a3a
Compare
The necessary updates to pnpm have been merged and are published in pnpm 7.17.1. This PR is ready for review/ merging whenever it becomes convenient. |
Just to make sure everyone sees it, I will also post down here: if you are on this branch, you must use pnpm version 7.17.1 or later, not npm. So make sure you have the necessary version of pnpm before pulling this branch. Thanks. |
My first instinct is to wait until the students are done, then merge, but we can discuss in today's meeting. |
Moves all of the markdown documentation of pnpm scripts into package.json5, thanks to its ability to have comments. Removes npm-run-all, as it is no longer being used. Resolves numberscope#140.
With the latest commit to this PR, the duplicated section between the two tests in the ci.yaml specification for github actions has gotten rather long/intricate, and should be textually collapsed for maintenance purposes even if it doesn't actually reduce the server work. Should I add a commit here that does that, or wait until this is merged and file a separate PR? Thanks for your thoughts. |
As long as we document the fact that we did some de-duplication of the YAML in the commit message that gets merged into main, I don't mind if you add the commit to this PR. |
Sadly this will have to wait until after the TU Delft project, since it now seems clear the team will clone the repository with an npm-managed version, and we definitely don't want to switch during that project. Or in other words: curses, foiled again. |
NOTE: If you pull this PR and want to operate with it, you must install pnpm version 7.17.1 or later, and use only pnpm for package management (do not use npm while on this branch!).
Switches this project to exclusively using the pnpm package manager. Benefits include faster performance, reduced disk space usage if you have multiple projects using pnpm (they share dependency code), and the ability to use the more human-readable JSON5 format for the package manifest file. Note that once this is merged, neither npm or yarn will be able to mange the packages for this project; rather, all developers will be obliged to use pnpm.
Resolves #140.