Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 974 fix - Update choices.xslt to fix the default blank option #1108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Maheshwaran17
Copy link

This fix is part of issue 974. This fix is to enhance the default blank option in the dropdown list so that the drop down is readable and disabled the default option so that it will prevent being selected by the user.

This fix is to enhance the default blank option in the dropdown list so that the drop down is readable and disabled the default option so that it will prevent being selected by the user.
@Maheshwaran17
Copy link
Author

I have made a change to have the disabled placeholder instead of blank option in the dropdown. Please find below the test result. Could you please let me know if you are fine with this fix. Please approve the you are happy with this fix otherwise let me know if in case of any suggestions. Thanks in advance!

Dropdown placeholder

@christianp
Copy link
Member

@Maheshwaran17 thanks for this. I don't think it quite does what we want, though: rather than disabling a "blank" option, it just shouldn't be there at all.

@Maheshwaran17
Copy link
Author

Hi @christianp , Thanks for the reply. If we remove the "blank" option , the first option is being selected by default and the page throws the below warning as soon as the question is loaded. Could you please let me know if we need to remove the "blank" and as well as NOT to show the below warnings. Could you pls advise on this. Thank you

warning

@christianp
Copy link
Member

@Maheshwaran17 what's going on in that question? It looks like it's in explore mode, but it has adaptive marking set up, and there's some asynchronous marking as well. The presence of every possible error message makes me think there's an HTML error in the template.
Is there anything in the developer console?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants