-
Notifications
You must be signed in to change notification settings - Fork 354
gha/add llvmlite osx 64 wheel builder #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gha/add llvmlite osx 64 wheel builder #1187
Conversation
esc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So suggestions and a question
Co-authored-by: Emergency Self-Construct <esc@users.noreply.github.com>
|
@swap357 thank you for the updates, looks like there are some CI issues to be resolved. |
|
@swap357 thank you for the fixes, I will review this again now. |
|
Testing protocol and results: a) merged this PR to esc/llvmlite@main: esc@0b15a08 b) used a GHA produced llvmdev from https://github.com/esc/llvmlite/actions/runs/14338724313 c) ran: https://github.com/esc/llvmlite/actions/runs/14354815563 This failed with: The error is that the llvmdev builder produces an artifact named Note that the string inserted above |
esc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I order to download the correct llvmdev artifact the correct artifact name must be used.
Co-authored-by: Emergency Self-Construct <esc@users.noreply.github.com>
|
Testing protocol for this PR. a) merged this PR at esc@a3a3bfc b) using the llvmdev artifact from https://github.com/esc/llvmlite/actions/runs/14338724313 c) launched https://github.com/esc/llvmlite/actions/runs/14360865808 to test this PR |
it passed, this can now be used to generate an artifact for the |
…oken for authentication
seibert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, though we can't check the upload wheel part (since it depends on a secret, which is not available in a pull request) until after this is merged.
|
FYI: I'm going to need to dismiss @esc 's review because he's not available for a week, and I want to keep this PR moving. If there are additional changes needed, they will have to go into another PR. |
I believe esc's requested changes have been made, but he's not available this week to update his approval.
No description provided.