fix: Ensure correct ABI filtering in CMake configuration #79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the build.gradle file to dynamically determine ABI filters
based on project requirements. Instead of relying on static ABI configurations,
the
reactNativeArchitectures()
function is introduced to fetch ABI filters fromproject properties or default to a standard set when not specified. This ensures
that only the necessary ABIs are processed during the build, addressing issues
related to incorrect ABI configurations.
Changes include:
reactNativeArchitectures()
function to fetch ABI filters dynamically.cmake
block in build.gradle to useabiFilters (*reactNativeArchitectures())
.This resolves issues where CMake attempted to build unnecessary ABIs, improving
build efficiency and reliability.
To test this change:
--active-arch
to ensure correct ABI detection.