Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set LogErrorAsStandardAttribute on GitTasks #1472

Closed
wants to merge 1 commit into from

Conversation

lg2de
Copy link
Contributor

@lg2de lg2de commented Nov 29, 2024

In #1470 was asked to activate LogErrorAsStandard for GitTasks to fix the problem, that git sometimes writes information to the error output even it is not an error.
The issue was closed because the request touches tool wrapper. So, here is the PR which should fix the issue.

The git Coding Guidelines states that different messages are send to error output.
We should check the exit code only.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

I did not check item 2 because I only realize the idea of @georg-eckert-zeiss.

@matkoch matkoch added this to the v9.0.2 milestone Nov 29, 2024
@matkoch matkoch closed this Nov 29, 2024
IT-VBFK added a commit to IT-VBFK/nuke that referenced this pull request Dec 1, 2024
@lg2de lg2de deleted the feature/git-error-output branch December 3, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants