Support Eslint 7 & add rules

.eslintrc

@@ -1,3 +1,3 @@
 {
-  "extends": "./base.js"
+  "extends": "./script.js"
 }

.gitignore

@@ -2,3 +2,4 @@
 node_modules/
 
 yarn.lock
+.npmrc

CHANGELOG.md

@@ -3,32 +3,34 @@
 ## Changes
 
 - **[Breaking]**: upgrade `eslint-plugin-react-hooks` to `^4.0.2`
-- **[Breaking]**: upgrade `eslint-plugin-flowtype` to `^5.1.0`
-- upgrade `eslint-plugin-react` to `^7.20.0`
+- **[Breaking]**: upgrade `eslint-plugin-flowtype` to `^5.2.0`
+- **[Breaking]**: remove `eslint-plugin-ramda` to `^5.1.0`
+- **[Breaking]**: minimum supported NodeJs version 12.18
+- upgrade `babel-eslint` to `^10.1.0`
+- upgrade `eslint-plugin-eslint-comments` to `^3.2.0`
+- upgrade `eslint-plugin-import` to `^2.22.0`
+- upgrade `eslint-plugin-jsx-a11y` to `^6.3.1`
+- upgrade `eslint-plugin-react` to `^7.21.2`
+- upgrade `eslint-plugin-react-hooks` to `^4.1.2`
 - Fix dependency list in README
 
 ## Likely to cause new errors
 
 - `require-atomic-updates`
-- `no-undefined`
 - `array-bracket-newline`
 - `func-names`: is now reported as error instead of warning
 - `func-style`
 - `lines-around-directive`: removed & replaced by `padding-line-between-statements`
 - `no-multiple-empty-lines`: `{ max: 1, maxBOF: 0, maxEOF: 0 }`
 - `no-restricted-syntax`: allow `for..of` usage
-- `sort-keys`
-- `flowtype/require-compound-type-alias`: `always`
 - `flowtype/require-readonly-react-props`
-- `flowtype/require-types-at-top`
-- `flowtype/type-import-style`: `identifier`
+- `flowtype/no-existential-type`
 - `import/no-namespace`
 - `import/order`: add `alphabetize: { order: 'asc' 'caseInsensitive': true }` & change `groups` to the following - `order: `builtin`, `external`, `internal`, `parent`, `sibling`
 - `import/no-unassigned-import`
 - `import/no-anonymous-default-export`: for functions & classes
 - `import/exports-last`
 - `import/group-exports`
-- `import/no-unused-modules`
 - `react/function-component-definition`
 - `react/jsx-key`
 - `react/no-direct-mutation-state`

README.md

@@ -29,7 +29,7 @@ We export two ESLint configurations for your usage.
 
 Our default export contains all of our ESLint rules, including ECMAScript 6+, FlowJS and React.
 
-It requires `eslint`, `eslint-plugin-import`, `eslint-plugin-react`, `eslint-plugin-ramda`, `eslint-plugin-react-hooks`,
+It requires `eslint`, `eslint-plugin-import`, `eslint-plugin-react`, `eslint-plugin-react-hooks`,
 `eslint-plugin-jsx-a11y` and `eslint-plugin-eslint-comments`. If you don't need React,
 see `eslint-config-nugit/base`.
 
@@ -39,6 +39,6 @@ see `eslint-config-nugit/base`.
 
 Our default export contains all of our ESLint rules, including ECMAScript 6+ and FlowJS.
 
-It requires `eslint`, `eslint-plugin-import`, `eslint-plugin-flowtype` and `eslint-plugin-ramda`.
+It requires `eslint`, `eslint-plugin-import` and `eslint-plugin-flowtype`.
 
 - Add `"extends": "nugit/base"` to your .eslintrc

base.js

@@ -8,7 +8,6 @@ module.exports = {
     './rules/es6',
     './rules/imports',
     './rules/strict',
-    './rules/ramda.js',
     './rules/flow.js',
     './rules/eslint-comments',
   ].map(require.resolve),
@@ -36,8 +35,8 @@ module.exports = {
       rules: {
         // Reports modules without any exports, or with unused exports
         // https://github.com/benmosher/eslint-plugin-import/blob/f63dd261809de6883b13b6b5b960e6d7f42a7813/docs/rules/no-unused-modules.md
-        'import/no-unused-modules': 'off'
-      }
+        'import/no-unused-modules': 'off',
+      },
     },
   ],
 };

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-nugit",
-  "version": "0.3.1",
+  "version": "1.0.0-alpha.5",
   "description": "Nugit's JS ESLint config, following our styleguide",
   "main": "index.js",
   "scripts": {
@@ -28,31 +28,29 @@
   },
   "homepage": "https://github.com/nugit/eslint-config-nugit",
   "devDependencies": {
-    "babel-eslint": "^10.0.3",
-    "eslint": "^6.8.0",
-    "eslint-plugin-eslint-comments": "^3.1.2",
-    "eslint-plugin-flowtype": "^5.1.0",
-    "eslint-plugin-import": "^2.19.1",
-    "eslint-plugin-jsx-a11y": "^6.2.3",
-    "eslint-plugin-ramda": "^2.5.1",
-    "eslint-plugin-react": "^7.20.0",
-    "eslint-plugin-react-hooks": "^4.0.2"
+    "babel-eslint": "^10.1.0",
+    "eslint": "^7.10.0",
+    "eslint-plugin-eslint-comments": "^3.2.0",
+    "eslint-plugin-flowtype": "^5.2.0",
+    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-jsx-a11y": "^6.3.1",
+    "eslint-plugin-react": "^7.21.2",
+    "eslint-plugin-react-hooks": "^4.1.2"
   },
   "peerDependencies": {
-    "babel-eslint": "^10.0.3",
-    "eslint": "^6.8.0",
-    "eslint-plugin-eslint-comments": "^3.1.2",
-    "eslint-plugin-flowtype": "^5.1.0",
-    "eslint-plugin-import": "^2.19.1",
-    "eslint-plugin-jsx-a11y": "^6.2.3",
-    "eslint-plugin-ramda": "^2.5.1",
-    "eslint-plugin-react": "^7.20.0",
-    "eslint-plugin-react-hooks": "^4.0.2"
+    "babel-eslint": "^10.1.0",
+    "eslint": "^7.10.0",
+    "eslint-plugin-eslint-comments": "^3.2.0",
+    "eslint-plugin-flowtype": "^5.2.0",
+    "eslint-plugin-import": "^2.22.1",
+    "eslint-plugin-jsx-a11y": "^6.3.1",
+    "eslint-plugin-react": "^7.21.2",
+    "eslint-plugin-react-hooks": "^4.1.2"
   },
   "engines": {
-    "node": ">= 6"
+    "node": ">= 12"
   },
   "dependencies": {
-    "confusing-browser-globals": "^1.0.7"
+    "confusing-browser-globals": "^1.0.9"
   }
 }

rules/flow.js

@@ -15,40 +15,35 @@ module.exports = {
     'flowtype/delimiter-dangle': ['error', 'always-multiline', 'always-multiline', 'always-multiline'],
     'flowtype/generic-spacing': ['error', 'never'],
     'flowtype/newline-after-flow-annotation': ['error', 'always'],
-    'flowtype/no-mixed': 'off',
-    'flowtype/no-dupe-keys': 'error',
-    // TODO: enable?
-    'flowtype/no-existential-type': 'off',
+    'flowtype/no-existential-type': 'error',
     'flowtype/no-flow-fix-me-comments': 'off',
     'flowtype/no-mixed': 'off',
-    // TODO: enable?
     'flowtype/no-mutable-array': 'off',
     'flowtype/no-primitive-constructor-types': 'error',
     'flowtype/no-types-missing-file-annotation': 'error',
     'flowtype/no-unused-expressions': 'error',
     // TODO: disable any?
     'flowtype/no-weak-types': ['error', { any: false }],
     'flowtype/object-type-delimiter': ['error', 'comma'],
-    'flowtype/require-compound-type-alias': ['error', 'always'],
+    'flowtype/require-compound-type-alias': ['off', 'always'],
     'flowtype/require-exact-type': 'off',
     'flowtype/require-indexer-name': 'off',
     'flowtype/require-inexact-type': 'off',
     'flowtype/require-parameter-type': 'off',
     'flowtype/require-readonly-react-props': 'error',
     'flowtype/require-return-type': 'off',
-    'flowtype/require-types-at-top': 'error',
+    'flowtype/require-types-at-top': 'off',
     'flowtype/require-valid-file-annotation': 'off',
     'flowtype/require-variable-type': 'off',
     'flowtype/semi': ['error', 'always'],
-    'flowtype/sort-keys': ['error', 'asc', { caseSensitive: false, natural: true }],
+    'flowtype/sort-keys': ['error', 'asc'],
     'flowtype/space-after-type-colon': ['error', 'always'],
     'flowtype/space-before-generic-bracket': ['error', 'never'],
     'flowtype/space-before-type-colon': ['error', 'never'],
-    // TODO: enable?
     'flowtype/spread-exact-type': 'off',
     'flowtype/type-id-match': 'off',
     // Use identifier as declaration imports are not well supported by vscode
-    'flowtype/type-import-style': ['error', 'identifier'],
+    'flowtype/type-import-style': ['off', 'declaration'],
     'flowtype/union-intersection-spacing': ['error', 'always'],
     'flowtype/use-flow-type': 'warn',
   },

rules/imports.js

@@ -150,13 +150,13 @@ module.exports = {
           ['external'],
           ['internal'],
           ['parent'],
-          ['sibling']
+          ['sibling'],
         ],
         'newlines-between': 'never',
         'alphabetize': {
-          'order': 'asc',
-          'caseInsensitive': true,
-        }
+          order: 'asc',
+          caseInsensitive: true,
+        },
       },
     ],
 
@@ -245,7 +245,7 @@ module.exports = {
 
     // Forbid cyclical dependencies between modules
     // https://github.com/benmosher/eslint-plugin-import/blob/d81f48a2506182738409805f5272eff4d77c9348/docs/rules/no-cycle.md
-    'import/no-cycle': ['error', { maxDepth: Infinity }],
+    'import/no-cycle': ['error', { ignoreExternal: true, maxDepth: Infinity }],
 
     // Ensures that there are no useless path segments
     // https://github.com/benmosher/eslint-plugin-import/blob/ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57/docs/rules/no-useless-path-segments.md
@@ -264,7 +264,7 @@ module.exports = {
 
     // Reports modules without any exports, or with unused exports
     // https://github.com/benmosher/eslint-plugin-import/blob/f63dd261809de6883b13b6b5b960e6d7f42a7813/docs/rules/no-unused-modules.md
-    'import/no-unused-modules': ['error', {
+    'import/no-unused-modules': ['off', {
       missingExports: true,
       unusedExports: true,
     }],

rules/react.js

@@ -57,7 +57,7 @@ module.exports = {
     // https://github.com/yannickcr/eslint-plugin-react/blob/v7.20.0/docs/rules/function-component-definition.md
     'react/function-component-definition': ['error', {
       namedComponents: 'function-declaration',
-      unnamedComponents: 'function-declaration',
+      unnamedComponents: 'function-expression',
     }],
 
     // Enforce boolean attributes notation in JSX

rules/style.js

@@ -447,7 +447,7 @@ module.exports = {
     'semi-style': ['error', 'last'],
 
     // requires object keys to be sorted
-    'sort-keys': ['error', 'asc', { caseSensitive: false, natural: true }],
+    'sort-keys': ['off', 'asc', { caseSensitive: false, natural: true }],
 
     // sort variables within the same declaration block
     'sort-vars': 'off',

rules/variables.js

@@ -32,7 +32,7 @@ module.exports = {
 
     // disallow use of undefined variable
     // https://eslint.org/docs/rules/no-undefined
-    'no-undefined': 'error',
+    'no-undefined': 'off',
 
     // disallow declaration of variables that are not used in the code
     'no-unused-vars': ['error', { vars: 'all', args: 'after-used', ignoreRestSiblings: true }],

script.js

@@ -1,11 +1,11 @@
 module.exports = {
-  extends: [
-    './base',
-  ].map(require.resolve),
   env: {
     'node': true,
     'shared-node-browser': false,
   },
+  extends: [
+    './base',
+  ].map(require.resolve),
   rules: {
     'import/no-extraneous-dependencies': [
       'error',
@@ -14,6 +14,7 @@ module.exports = {
         optionalDependencies: false,
       },
     ],
+    'import/no-unused-modules': 'off',
     'no-console': 'off',
   },
 };