-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: adapt s3 acl tests to new default behavior #894
base: master
Are you sure you want to change the base?
Conversation
@roman-khimov shouldn't it be 2 different actions to enable ACLs for objects and buckets? Right now this command:
Enables ACLs both for objects and buckets, another thing - only this Action is accepted - |
I think it's better to be verified against Amazon. But I've also found nspcc-dev/neofs-s3-gw#1023 and nspcc-dev/neofs-s3-gw#1022. |
5027067
to
fd7a3ae
Compare
@smallhive why are we requiring this: |
It should be valid, in the |
@smallhive @roman-khimov this is different from the amazon behavior. With BucketOwnerPreferred, any object ACLs can be set, if there are no other policies. But if a bucket owner wants, there is a possibility to add a policy to make object writers to forcefully specify bucket-owner-full-control. This is what docs is about. This behavior shouldn't be enforced by default, but should be enabled via policies. If we want to behave the same as the amazon s3 implementation. |
Move it to additional issue, please. This can be fixed, so it should be fixed. |
fd7a3ae
to
5f22b48
Compare
closes #885 Signed-off-by: Evgeniy Zayats <[email protected]>
5f22b48
to
e92be4c
Compare
closes #885