go.mod: switch to nspcc-dev/bbolt completely #3576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
roman-khimov
commented
Sep 11, 2025
roman-khimov
commented
- It updates to BoltDB 1.4.3 effectively with some fixes (but requires additional testing now).
- We can't solve replace directive in go.mod makes it harder to "go install" neo-go neo-go#3964 without using a module of our own and we want to use the same BoltDB version in all projects.
- This is supposed to be temporary, but no one knows how long db: rework metalock into RWMutex etcd-io/bbolt#998 (or some alternative) will take.
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
1. It updates to BoltDB 1.4.3 effectively with some fixes (but requires additional testing now). 2. We can't solve nspcc-dev/neo-go#3964 without using a module of our own and we want to use the same BoltDB version in all projects. 3. This is supposed to be temporary, but no one knows how long etcd-io/bbolt#998 (or some alternative) will take. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
nspcc-bbolt
branch
from
d1db172 to
23f9543
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3576 +/- ##
==========================================
- Coverage 25.98% 25.97% -0.02%
==========================================
Files 660 660
Lines 49738 49738
==========================================
- Hits 12926 12917 -9
- Misses 35775 35782 +7
- Partials 1037 1039 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.