-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small open_virtual_dataset bugs #923
Conversation
👈 Launch a binder notebook on this branch for commit 8f9d27e I will automatically update this comment whenever this PR is modified 👈 Launch a binder notebook on this branch for commit d5ca8c7 👈 Launch a binder notebook on this branch for commit 63f36b6 👈 Launch a binder notebook on this branch for commit 3d3a279 👈 Launch a binder notebook on this branch for commit 529b5ca 👈 Launch a binder notebook on this branch for commit f39b151 |
Note that this PR changes the dmrpp tests to no longer verify the result of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, sorry for the delay. Is this the last thing we need before adding example notebooks and releasing 0.13.0? cc @ayushnag
oops, looks like there are some failing integration tests. e.g.
I wonder if it's related to JPL's outage. I'll debug locally. |
@betolink Thanks for reviewing and pushing the fixes! I believe zarr v3 doesn't break the parser, v3 is not yet compatible with kerchunk. However, kerchunk is needed for the |
Ahhh good to know! ok so let's get this merged and then work on the notebooks so we can have a virtualizarr release next week! @ayushnag |
📚 Documentation preview 📚: https://earthaccess--923.org.readthedocs.build/en/923/