[#24] throw exception/log error for file separator characters#25
Merged
iadgovuser59 merged 9 commits intomainfrom Jan 30, 2026
Merged
[#24] throw exception/log error for file separator characters#25iadgovuser59 merged 9 commits intomainfrom
iadgovuser59 merged 9 commits intomainfrom
Conversation
Code cleanup
Specify charset encoding in ValidatorCmdVerify
chubtub
changed the title
iadgovuser59
requested review from
iadgovuser59
and removed request for
iadgovuser26
iadgovuser59
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes include:
Testing:
Test 2 in the updated test script is an example of how the create command will handle invalid support RIM filenames.
rim_fields_bad_supportRIM.jsonspecifies a support RIM with namepcrim/TpmLog.bin. When this config file is passed to the rimtool the expected error message is,Support RIM(s) were found with file separator characters in their names, please remove and retry.Closes #24