Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pciids calls from windows machines #843

Merged
merged 14 commits into from
Oct 24, 2024
Merged

fix pciids calls from windows machines #843

merged 14 commits into from
Oct 24, 2024

Conversation

iadgovuser58
Copy link
Collaborator

@iadgovuser58 iadgovuser58 commented Sep 26, 2024

Closes #836

Pci.ids file is only searched in linux locations, so any calls from a windows machine cause a build error. Also, for linux machines there was no guarantee that the machine had the pci.ids file, so need that as a dependency.

  1. fix build error so that if file is not found, it handles the error gracefully (rather than print out an exception)
  2. add hwdata as a dependency; hwdata is the linux package that downloads pci.ids to a linux system
    in build.gradle files for both ACA and eventlogtool:
    ospackage {
    ...
    requires('hwdata', '0.314', GREATER | EQUAL)
    ...
    }
  3. add pci.ids file to utils resources as a backup option; if the pci.ids file is not found on the filesystem (as will occur on a windows system), then the code will use the pci.ids file from the code resources

@iadgovuser58 iadgovuser58 added the bug Something isn't working label Sep 26, 2024
@iadgovuser58 iadgovuser58 self-assigned this Sep 26, 2024
@iadgovuser58 iadgovuser58 merged commit b163691 into main Oct 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix pciids calls from windows machines
2 participants