Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) [#705] /list page Order fix #742

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

cyrus-dev
Copy link
Contributor

This covers the 2nd bullet of #705. This is incomplete but functions, someone should be able to pick this up and update the associated pages.

@iadgovuser58
Copy link
Collaborator

iadgovuser58 commented Mar 27, 2024

T's changes for order fix:

  • HIRS_AttestationCA/src/main/java/hirs/attestationca/persist/entity/manager/CACredentialRepository.java
  • HIRS_AttestationCAPortal/src/main/java/hirs/attestationca/portal/page/controllers/CertificatePageController.java

Changes to fix error in unit test in DeviceInfoReportTest:
** UPDATE: changes for DeviceInfoReportTest fix have now been implemented in PR #760 per issue #759. The changes are still here as well but should be the same. **

  • HIRS_AttestationCA/src/test/java/hirs/attestationca/persist/entity/userdefined/report/DeviceInfoReportTest.java
  • HIRS_AttestationCA/src/test/resources/VERSION (removed)
  • HIRS_Utils/src/test/java/hirs/utils/VersionHelperTest.java
  • HIRS_Utils/src/test/resources/VERSION (removed)

Changes to get IssuedCertificatesPageControllerTest to pass:

  • HIRS_AttestationCAPortal/src/test/java/hirs/attestationca/portal/page/controllers/IssuedCertificatesPageControllerTest.java
  • HIRS_AttestationCAPortal/src/main/java/hirs/attestationca/portal/page/controllers/CertificatePageController.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants