cleanup(js): replace fs-extra with node:fs

[ziebam]

This PR is a suggestion to replace fs-extra with the native node:fs to reduce the dependency count and the bundle size.

Current Behavior

@nx/js uses fs-extra which, at present, mostly wraps the native node:fs API.

The biggest change is fs-extra.copySync -> fs.cpSync. The latter has been added in Node 16.7.0, and has been marked as "experimental" since, dropping that status in Node 22. The API seems stable across the releases though, and the affected tests pass, so this change might be acceptable. Other possible solutions:

1. Keep fs-extra just for this function, and eventually remove it in the distant future where Node version older than 22 are deemed obsolete.
2. Mirror the cpSync behavior by writing a utility that uses stable methods fs.writeFile, fs.stat, etc.

Expected Behavior

Reduced dependency count and bundle size by replacing fs-extra with node:fs.

Related Issue(s)

N/A

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Sep 17, 2024 11:04am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0f65580. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 4 targets

• nx affected --targets=lint,test,build,e2e,e2e-ci --base=71fe65ffbda3a55a31c164566bc73604ec05d157 --head=0f65580641df53b70c189ad9d36411fd6fca1a31 --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=71fe65ffbda3a55a31c164566bc73604ec05d157 --head=0f65580641df53b70c189ad9d36411fd6fca1a31
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[JamesHenry]

Thank you for this @ziebam.

It could possibly cause issues for any in flight branches/PRs. To help make things easier to both figure out and enforce, please add something like the following ESLint rule to the js package .eslintrc.json

"no-restricted-imports": ["error", {
    "name": "fs-extra",
    "message": "Please use equivalent utilties from `node:fs` instead."
}]

[ziebam]

Thank you for this @ziebam.

It could possibly cause issues for any in flight branches/PRs. To help make things easier to both figure out and enforce, please add something like the following ESLint rule to the js package .eslintrc.json

"no-restricted-imports": ["error", {
    "name": "fs-extra",
    "message": "Please use equivalent utilties from `node:fs` instead."
}]

Done. I also merged with master, although that might have erroneously triggered GitHub to ask another person for a review, apologies.

[JamesHenry]

@ziebam So you tested this catches cases of importing from fs-extra, yeah?

[ziebam]

@ziebam So you tested this catches cases of importing from fs-extra, yeah?

Yup, here's a screenshot for the record.

Not sure about the CI failure, investigating right now.

[JamesHenry]

Thanks @ziebam