fix(core): add flag to disable the db and logs when there are errors … #27930
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 49d1e4b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
| @@ -663,7 +663,9 @@ function constructLifeCycles(lifeCycle: LifeCycle) { | |||
| } | |||
| if (!isNxCloudUsed(readNxJson())) { | |||
| lifeCycles.push( | |||
| !IS_WASM ? new TaskHistoryLifeCycle() : new LegacyTaskHistoryLifeCycle() | |||
| process.env.NX_DISABLE_DB === 'true' || !IS_WASM | |||
There was a problem hiding this comment.
| process.env.NX_DISABLE_DB === 'true' || !IS_WASM | |
| process.env.NX_DISABLE_DB !== 'true' && !IS_WASM |
FrozenPandaz
force-pushed
the
db-logs
branch
from
c2b60ec
to
8efbad5
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27930-8efbad5
To request a new release for this pull request, mention someone from the Nx team or the |
FrozenPandaz
force-pushed
the
db-logs
branch
from
8efbad5
to
e871993
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27930-e871993
To request a new release for this pull request, mention someone from the Nx team or the |
…connecting to the db
FrozenPandaz
force-pushed
the
db-logs
branch
from
e871993
to
49d1e4b
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspaceOr just copy this version and use it in your own command: 0.0.0-pr-27930-49d1e4b
To request a new release for this pull request, mention someone from the Nx team or the |
#27930) …connecting to the db <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> There is no flag to disable the DB and little logs for when Nx fails to connect to the DB. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> There is a `NX_DISABLE_DB=true` flag which can be used to disable usage of the DB. There are more logs which should help us identify what exactly is failing when connecting to the DB. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit e5f52ca)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
…connecting to the db
Current Behavior
There is no flag to disable the DB and little logs for when Nx fails to connect to the DB.
Expected Behavior
There is a
NX_DISABLE_DB=trueflag which can be used to disable usage of the DB. There are more logs which should help us identify what exactly is failing when connecting to the DB.Related Issue(s)
Fixes #