-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(nx-cloud): update reference to start-ci-run and complete-ci-run #27909
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
078bfcd
to
926363d
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fd139f9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
926363d
to
02c7a3f
Compare
02c7a3f
to
11cf5ff
Compare
11cf5ff
to
5dd69d4
Compare
5dd69d4
to
39af721
Compare
39af721
to
f728762
Compare
f728762
to
0671716
Compare
0671716
to
a1e118b
Compare
a1e118b
to
fd139f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a suggestion to reorder some text. You'll be able to make the change and immediately merge.
@@ -80,14 +80,13 @@ You can configure your CI run by passing the following flags: | |||
|
|||
### --distribute-on | |||
|
|||
Tells Nx Cloud how many agents to use (and what launch templates to use) to distribute tasks. E.g., | |||
By default, `npx nx-cloud start-ci-run` is intended for use with [Nx Agents](/ci/features/distribute-task-execution) and expects `--distribute-on` to be configured. It will output a warning if this flag is not set. If you are running a distributed execution with a legacy setup without Nx Agents, you can pass `--distribute-on=manual` to disable this warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this paragraph to be the second paragraph in this section. The definition of the flag should be the first paragraph and then this caveat paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aw crud didn't see this comment before I merged. Will make another PR 🤦
…27909) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Updated references about start-ci-run to include mentions of warnings that you get if you don't include the `--distribute-on` flag. Also removed references to the legacy `--stop-all-agents` command in favor of `--complete-ci-run`. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Expected Behavior
Updated references about start-ci-run to include mentions of warnings that you get if you don't include the
--distribute-on
flag.Also removed references to the legacy
--stop-all-agents
command in favor of--complete-ci-run
.Related Issue(s)
Fixes #