Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add plugin for inferring nodes from angular.json files #27804

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Sep 6, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Sep 6, 2024
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 17, 2024 0:54am

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments, but overall looks good

packages/angular/src/plugins/plugin.ts Outdated Show resolved Hide resolved
packages/angular/src/plugins/plugin.ts Show resolved Hide resolved
packages/angular/src/plugins/plugin.ts Outdated Show resolved Hide resolved
packages/angular/src/plugins/plugin.ts Show resolved Hide resolved
packages/angular/src/plugins/plugin.ts Show resolved Hide resolved
packages/angular/src/plugins/plugin.ts Show resolved Hide resolved
@leosvelperez leosvelperez force-pushed the angular/crystal-plugin branch 2 times, most recently from 55239cf to 036e179 Compare September 9, 2024 18:51
@jaysoo jaysoo requested a review from a team as a code owner September 12, 2024 19:36
@jaysoo jaysoo force-pushed the angular/crystal-plugin branch 10 times, most recently from a28e4f2 to 3cd2975 Compare September 13, 2024 15:41
@jaysoo jaysoo force-pushed the angular/crystal-plugin branch 10 times, most recently from 10c610d to b920b8a Compare September 16, 2024 20:46
Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-27804-bc6b179
Release details 📑
Published version 0.0.0-pr-27804-bc6b179
Triggered by @jaysoo
Branch angular/crystal-plugin
Commit bc6b179
Workflow run 10891691523

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@jaysoo jaysoo force-pushed the angular/crystal-plugin branch 2 times, most recently from 4850e99 to 3c55f4c Compare September 16, 2024 21:18
@jaysoo jaysoo merged commit e0b3e73 into master Sep 17, 2024
6 checks passed
@jaysoo jaysoo deleted the angular/crystal-plugin branch September 17, 2024 15:00
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants