Fix: set triggervalue per channel

[mint-dewit]

About the Contributor

This pull request is posted on behalf of BBC.

Type of Contribution

This is a: Fix

Current Behavior

When setting a triggerValue on a object with type TimelineContentTypeSisyfos.CHANNEL the trigger value would be set globally.

New Behavior

The trigger value on a channel type object sets the trigger value only for that channel. Some additional comments have been added to the types to clarify the behaviour better.

Testing Instructions

From a quick look this should not be affecting NRK at all.

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 56.55%. Comparing base (58cfbb2) to head (54734d5).

Files with missing lines	Patch %	Lines
...e-state-resolver/src/integrations/sisyfos/index.ts	0.00%	10 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release52     #350      +/-   ##
=============================================
- Coverage      56.60%   56.55%   -0.05%     
=============================================
  Files            131      131              
  Lines          10265    10274       +9     
  Branches        2489     2509      +20     
=============================================
  Hits            5810     5810              
- Misses          4453     4462       +9     
  Partials           2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.