-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for schema validation of blueprintConfiguration objects #1223
Open
scriptorian
wants to merge
6
commits into
nrkno:release52
Choose a base branch
from
evs-broadcast:feat/blueprint-config-validation
base: release52
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Support for schema validation of blueprintConfiguration objects #1223
scriptorian
wants to merge
6
commits into
nrkno:release52
from
evs-broadcast:feat/blueprint-config-validation
+773
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release52 #1223 +/- ##
==============================================
+ Coverage 57.91% 70.66% +12.74%
==============================================
Files 525 17 -508
Lines 84945 3596 -81349
Branches 4438 345 -4093
==============================================
- Hits 49200 2541 -46659
+ Misses 35689 1054 -34635
+ Partials 56 1 -55 ☔ View full report in Codecov by Sentry. |
nytamin
added
Contribution from EVS
Contributions sponsored by EVS Broadcast Equipment (evs.com)
Contribution
labels
Jul 9, 2024
Thank you for this contribution! The NRK team is on vacation at the moment, we'll look at this PR when we're back in August. |
Julusian
reviewed
Jul 30, 2024
nytamin
reviewed
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been opened by SuperFly.tv on behalf of EVS Broadcast Equipment.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behaviour? (You can also link to an open issue here)
When updating blueprintConfiguration objects through the REST API the new configuration is written to the database without any validation that the values conform to any schema.
What is the new behaviour (if this is a feature change)?
This feature supports blueprints that define blueprintConfiguration object JSON schemas and provides methods to support automatic, detailed validation of updated configurations against the published schema before being written to the database. Any invalid properties are reported back to the client.
Included is a small addition to the API that allows the blueprintConfiguration objects to be read and updated without including the rest of the studio or showStyle configuration properties.
Other information:
Status
Affected Areas