ed448 key size 456 bits #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PFnord
force-pushed
the
ed448_key_size_v2
branch
from
e7c8e4e to
296d081
Compare
magnev
approved these changes
Dec 17, 2024
magnev
reviewed
Dec 17, 2024
| @@ -270,7 +270,7 @@ | |||
| #elif defined(PSA_WANT_ECC_MONTGOMERY_448) | |||
| #define PSA_VENDOR_ECC_MAX_CURVE_BITS 448u | |||
| #elif defined(PSA_WANT_ECC_TWISTED_EDWARDS_448) | |||
| #define PSA_VENDOR_ECC_MAX_CURVE_BITS 448u | |||
There was a problem hiding this comment.
Wait, this must be moved above the PSA_WANT_ECC_MONTGOMERY_448 since it's bigger
PFnord
force-pushed
the
ed448_key_size_v2
branch
from
296d081 to
556875c
Compare
|
please add [nrf noup] in the commit message |
PFnord
force-pushed
the
ed448_key_size_v2
branch
from
556875c to
deb0c4b
Compare
|
Can you also add the description in your PR to the commit message? So that we can track what's happening from git without using github? |
RFC8032 mentions the length of a key for ed448 and ed448ph to be 57 bytes (456 bits). Using 448 bits as a max length creates a buffer overflow warning when building with ED448 enabled.
PFnord
force-pushed
the
ed448_key_size_v2
branch
from
deb0c4b to
73908de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems from spec rfc8032 The length of a key for ed448 and ed448ph is 57 bytes (456 bits).
Using 448 bits as a max length creates a buffer overflow warning when building with ED448 enabled.